383217 - discard bind and Function.prototype.bind in favor of BindToObject

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[Simon Bünzli]

... which is used everywhere opposed to the first two which are both called exactly from one place: BindToObject.

Comment 1

[Simon Bünzli]

Attachment: fix

Comment 2

[Tony Chang (Google)]

Comment on attachment 267217 [details] [diff] [review]
fix

>Index: lang.js
>+ * @param opt_{...} Dummy optional arguments to make a jscompiler happy
>+function BindToObject(fn, self, opt_A, opt_B, opt_C, opt_D, opt_E, opt_F) {

Nit: We should just remove the opt_* args since the jscompiler that's referred to here is a Google specific tool.

Comment 3

[Tony Chang (Google)]

I'm not going to submit this until bug 383269 is resolved for fear of making the test case un-reproducible.

Comment 4

[Simon Bünzli]

Attachment: fix (with only minimal opt_* arguments)

Comment 5

[Kenneth Herron]

Checked in "fix (with only minimal opt_* arguments)". Clearing checkin-needed status.