Comment 1 Daniel Boelzle [:dbo] 2007-06-06 07:43:07 PDT

Created attachment 267417 [details] [diff] [review]
fallback to DUE if no DTSTART is present

Comment 2 Stefan Sitter 2007-06-07 01:48:55 PDT

Adding the error messages as shown in console to make it possible to search and reference them:

Error: Import error: [Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [calIRecurrenceItem.getOccurrences]"  nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)"  location: "JS frame :: file:///D:/sunbird/js/calRecurrenceInfo.js :: anonymous :: line 432"  data: no]
Source file: chrome://calendar/content/import-export.js
Line: 196

Error: Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [calIRecurrenceItem.getOccurrences]
Source file: file:///D:/sunbird/js/calRecurrenceInfo.js
Line: 432

Comment 3 Michiel van Leeuwen (email: mvl+moz@) 2007-06-10 12:16:34 PDT

Comment on attachment 267417 [details] [diff] [review]
fallback to DUE if no DTSTART is present

r=mvl

Comment 4 Daniel Boelzle [:dbo] 2007-06-28 23:30:19 PDT

Checked in on HEAD and MOZILLA_1_8_BRANCH.

Comment 5 Daniel Boelzle [:dbo] 2007-08-08 01:01:54 PDT

Unfortunately bug 386502 has caused a regression:

Error: [Exception... "Component returned failure code: 0x80004003 
(NS_ERROR_INVALID_POINTER) [calIDateTime.compare]" nsresult: "0x80004003 
(NS_ERROR_INVALID_POINTER)" location: "JS frame :: 
... 
:: checkRange :: line 372" data: no]
Source File: 
... calRecurrenceInfo.js
Line: 372

Comment 6 Daniel Boelzle [:dbo] 2007-08-08 01:06:57 PDT

Created attachment 275745 [details] [diff] [review]
fallback to DUE if no DTSTART is present

- fallback to DUE if no DTSTART available, make either one mandatory
- checkRange now might also return DUE: I've renamed variable dtstart to occDate

Comment 7 Sebastian Schwieger 2007-08-08 16:23:02 PDT

The patch looks fine. A comment in the code regarding the fallback might be nice. 

Just two more comments:
1. I wonder if there are other places in the file that need to be changed to fully support recurring task with no start date set. A quick search revealed two more places where item.getProperty("DTSTART") is used. I think you know better than me if they require additional care.

2. Month and MultiWeek View do not support this fallback. A follow up should be filed (if it not yet exists).

Sorry for having caused this regression :(

Comment 8 Daniel Boelzle [:dbo] 2007-08-09 00:47:39 PDT

(In reply to comment #7)
> 1. I wonder if there are other places in the file that need to be changed to
> fully support recurring task with no start date set. A quick search revealed
> two more places where item.getProperty("DTSTART") is used. I think you know
> better than me if they require additional care.
I filed follow-up bug 391495 for that.

> 2. Month and MultiWeek View do not support this fallback. A follow up should be
> filed (if it not yet exists).
Could you please research that?

> Sorry for having caused this regression :(
No problem at all; I've reviewed your patch ;)
Thanks to Andreas finding this during bug verification.

Comment 9 Daniel Boelzle [:dbo] 2007-08-09 00:56:52 PDT

Checked in on HEAD and MOZILLA_1_8_BRANCH.

Comment 10 Andreas Treumann 2007-08-09 05:40:00 PDT

Verified in Lightning and Sunbird (20070809 builds) -> task is fixed.

Comment 11 Sebastian Schwieger 2007-08-11 13:49:48 PDT

(In reply to comment #8)
> Could you please research that?
Bug 349529 is already filed for this. Actually with this fix, the only task-with-only-due-date-set that shows up in the views is the parent item of a recurring event (and probably exceptions thereof).