383512 - Make gfx support text drawing onto any surface type

Status: RESOLVED FIXED

(Core Graveyard :: GFX: Win32, defect)

Description

[Robert Longson [:longsonr]]

Attachment: patch

Comment 1

[Robert Longson [:longsonr]]

Attachment: simplify ReleaseDC check

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 267549 [details] [diff] [review]
simplify ReleaseDC check

This is more Stuart's thing

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Not gonna block, but I really really would like to have this...

Comment 4

[Robert Longson [:longsonr]]

Would you like to review it then?

Comment 5

[Eli Friedman]

Is the measurement result from GetDC(0) the same as that for the DC from the surface in all cases?  I'm particularly worried about printing; it seems quite possible that text measurement works differently there due to different hinting.  It's quite possible that it isn't different, though; I wouldn't be surprised if that's the case since Mac and Linux seem to do device-independent text measurement.

Actually, if the DC from GetDC(0) is just as good as any other DC, we should just do that unconditionally to simplify the code.

Comment 6

[Robert Longson [:longsonr]]

It's rather hard to tell as printing and print preview of any SVG has been broken on Windows for a long time now. On Windows SVG comes out really tiny. C.f. bug 314707 comment 16 although you can no longer build the trunk with --enable-default-toolkit=windows

Comment 7

[Eli Friedman]

Oh, right... that's bug 370006.

Comment 8

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: win32 text on any surface

Here's an even simpler version of this patch... uses a helper class to manage obtaining the DC and the conversion.

Comment 9

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Was checked in.