383532 - [Mac][Classic][Suiterunner] Twisty icons missing (twisty-open.gif/png, twisty-clsd.gif/png)

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Karsten Düsterloh]

Self-built "Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a6pre) Gecko/2007060216 SeaMonkey/2.0a1pre", Suiterunner with Classic theme.

Chrome file doesn't exist: /Users/karsten/Projekte/Mozilla/obj/soc/dist/SeaMonkeyDebug.app/Contents/MacOS/chrome/classic/skin/classic/global/tree/twisty-clsd.gif
Chrome file doesn't exist: /Users/karsten/Projekte/Mozilla/obj/soc/dist/SeaMonkeyDebug.app/Contents/MacOS/chrome/classic/skin/classic/global/tree/twisty-clsd.png
Chrome file doesn't exist: /Users/karsten/Projekte/Mozilla/obj/soc/dist/SeaMonkeyDebug.app/Contents/MacOS/chrome/classic/skin/classic/global/tree/twisty-open.gif

MailNews should show a twisty before email address lists in mail headers, but does not. This is because Pinstripe, the default Classic theme for toolkit on Mac, does not contain the relevant icons (trees use native ones?). Winstripe (for Windows) has them and Linux, too (Gnomestripe is based on Winstripe).

Thunderbird obviously had the same problem and thus has its own special Pinstripe twisty icons. 

Since we can't tinker with toolkit theming, we have these options in /themes/classic/jar.mn:
- package the old XPFE icons
- package Thunderbird's icons from /mail 
- package our own new icons

I think we should combine the last two and have our own copies of the TB icons if possible - we shouldn't depend upon /mail - since the XPFE icons will most probably not quite fit.

Comment 1

[Robert Kaiser]

IMHO, it's probably a bug that winstripe has them and pinstripe hasn't, I wonder why they're so inconsistent there.

If the solution is not that pinstripe not having them is an incosistency to be solved, we should ship our own twisty icons either in communicator/ or mailnews/ depending on where they're supposed to be used.

Comment 2

[[e-mail]]

Where are the style rules for these icons? Can we add
-moz-appearance: treetwisty; and -moz-appearance: treetwistyopen; to them?

Comment 3

[Karsten Düsterloh]

> Where are the style rules for these icons?

For MailNews, it's in themes/classic/messenger/messageHeaders.css, in the classes .addresstwisty, .addresstwisty[open], .expandedHeaderViewButton and .collapsedHeaderViewButton.

> Can we add -moz-appearance: treetwisty; and -moz-appearance: treetwistyopen;
> to them?

Yes, excellent, that brings back the twisties!
But: - Mac twisties are very large, I had to set "margin-top: -3px" to make
       it look nice, so we probably need a Mac overload here
       (or some preprocessing in the CSS :-/)
     - using these appearances, I run into the "disappearing email twisty"
       bug seen also on other platforms (like bug 366825).

I think we probably should fix the missing appearance first without touching any styling to make MailNews usable again...

Comment 4

[Karsten Düsterloh]

Attachment: add twisty appearances, don't touch styling

Band-aid patch to get MailNews working again.

Comment 5

[Karsten Düsterloh]

Attachment: add twisty appearances, don't touch styling, correct version

Oops, wrong order in attachment 267606 [details] [diff] [review]. :(

Comment 6

[Karsten Düsterloh]

Attachment: MailNews with patch 267635 (collapsed headers)

Applying the tree twisties without style changes positions the twisty too low for subject and email address nodes in the headerpane.

Comment 7

[Karsten Düsterloh]

Attachment: MailNews with patch 267635 (expanded headers)

Comment 8

[[e-mail]]

Comment on attachment 267635 [details] [diff] [review]
add twisty appearances, don't touch styling, correct version

OK, after speaking to Mano on IRC I agree that using native twisties isn't the right way to go, instead the xpfe Mac twisties should be copied into mailnews and used on all platforms (they look more appropriate than the Windows twisties anyway), until Manuel produces some better twisties.

Comment 9

[Karsten Düsterloh]

> the xpfe Mac twisties should be copied into mailnews and used on all
> platforms (they look more appropriate than the Windows twisties
> anyway)

You really mean using /themes/classic/global/mac/tree/twisty-clsd.gif and twisty-open.gif even for Classic on Windows?!

OTOH, I think that we should use separate icons for the "twisty" used to toggle between normal and brief header layout and the "twisty" used for toggling singleline/multiline email addresses, especially when we get multiline text headers by bug 23114 - but I'll file a new bug on that.

Comment 10

[Karsten Düsterloh]

Bug 383940 filed.

Comment 11

[Stefan [:stefanh]]

Can't we use the thunderbird ones? IMO they're nicer.

Comment 12

[Karsten Düsterloh]

> Can't we use the thunderbird ones? IMO they're nicer.

You mean /mail/themes/pinstripe/mail/icons/twisty-open.gif and twisty-closed.gif?

Comment 13

[Stefan [:stefanh]]

(In reply to comment #12)
> > Can't we use the thunderbird ones? IMO they're nicer.
> 
> You mean /mail/themes/pinstripe/mail/icons/twisty-open.gif and
> twisty-closed.gif?
> 

Yes. I haven't tried them though.

Comment 14

[Stefan [:stefanh]]

(In reply to comment #13)
> (In reply to comment #12)
> > > Can't we use the thunderbird ones? IMO they're nicer.
> > 
> > You mean /mail/themes/pinstripe/mail/icons/twisty-open.gif and
> > twisty-closed.gif?
> > 
> 
> Yes. I haven't tried them though.
>
Sorry, I ment
mail/themes/pinstripe/mail/icons/treetwisty.png
mail/themes/pinstripe/mail/icons/treetwisty-open.png

Comment 15

[[e-mail]]

I don't like any of the Thunderbird ones, they look really boring.

Comment 16

[Karsten Düsterloh]

Pushing onto 2.0 radar.

Comment 17

[Ian Neal]

Attachment: classic jar.mn patch v0.1

This patch:
* Adds the relevant lines to the jar.mn

As well as the patch would be cvs adding global and global/tree directories as well as cvs adding twisty-open.gif and twisty-clsd.gif from /themes/classic/global/mac/tree

Comment 18

[Ian Neal]

(In reply to comment #17)
> Created an attachment (id=330669) [details]
> classic jar.mn patch v0.1
> 
> This patch:
> * Adds the relevant lines to the jar.mn
> 
> As well as the patch would be cvs adding global and global/tree directories as
> well as cvs adding twisty-open.gif and twisty-clsd.gif from
> /themes/classic/global/mac/tree
> 
This patch should also fix bug 382642

Comment 19

[[e-mail]]

Comment on attachment 330669 [details] [diff] [review]
classic jar.mn patch v0.1

As I would have said on IRC (had I not been rudely disconnected by a broken timer) suite/themes/classic has no global, it gets global from toolkit.

Comment 20

[Ian Neal]

(In reply to comment #19)
> (From update of attachment 330669 [details] [diff] [review])
> As I would have said on IRC (had I not been rudely disconnected by a broken
> timer) suite/themes/classic has no global, it gets global from toolkit.
> 
Yes, which is why I said I would have to cvs add global and cvs add global/tree to the /suite/themes/classic directory

Comment 21

[Ian Neal]

Attachment: classic jar.mn patch v0.2

Changes since v0.1:
* messageHeader.css now looks in classic/messenger/icons for twisty-clsd.gif and twisty-open.gif
* jar.mn packages those two icons from classic/messenger/icons

Would be cvs adding copies of the two icons from /themes/classic/global/mac/tree

Comment 22

[[e-mail]]

Comment on attachment 330670 [details] [diff] [review]
classic jar.mn patch v0.2

Bonus points for converting them to .PNG format to match the rest of base mailnews :-)

Comment 23

[Ian Neal]

Attachment: classic jar.mn/css patch v0.2a (Checked in)

Changes since v0.2:
* icons are now png

Carrying forward r/sr

Comment 24

[Ian Neal]

Comment on attachment 330738 [details] [diff] [review]
classic jar.mn/css patch v0.2a (Checked in)

Checking into trunk
jar.mn; new revision: 1.176; previous revision: 1.175
messenger/messageHeader.css; new revision: 1.12; previous revision: 1.11
messenger/icons/twisty-clsd.png; initial revision: 1.1
messenger/icons/twisty-open.png; initial revision: 1.1
done