383580 - _cairo_quartz_surface_acquire_source_image leaks

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Mats Palmgren (inactive)]

Attachment: A few allocation stacktraces for memory that leaked

STEPS TO REPRODUCE
1. setup suitable values for MallocStackLogging etc, see [1]
2. start Firefox
3. figure out its PID then run 'leaks PID'

ACTUAL RESULTS
Leaks, see attached log file.

[1] http://developer.apple.com/documentation/Performance/Conceptual/ManagingMemory/Articles/MallocDebug.html

Comment 1

[Mats Palmgren (inactive)]

Attachment: grep -rsI -A1 urface_acquire_source_image, gfx/

Hmm, so everyone that implements surface_acquire_source_image also has
a matching surface_release_source_image, except cairo-quartz-surface.c

Comment 2

[Mats Palmgren (inactive)]

Attachment: fix?

DISCLAIMER: I really don't know this code but this patch makes the
leaks disappear and Firefox haven't crashed so far...

Comment 3

[Brian Ewins]

Already fixed on cairo trunk by Boris Zbarsky
http://gitweb.freedesktop.org/?p=cairo;a=commitdiff;h=fcdfda83655faf0eecbb2b5af09a05340fe422e6

I thought Boris' patch originated in minefield, but I guess not.

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Should be fixed by the cairo upgrade