383960 - Upgrade cairo to 1.5.x

Status: RESOLVED FIXED

(Core :: Graphics, defect, P1)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Tracking bug for the cairo upgrade to 1.4.8.

Comment 1

[Brian Ewins]

blocks - and should fix - bug 379321, bug 383580, bug 367134 ... but I don't have perms to say that.

Possibly also bug 380409, looks like the same stroke-width issue that I patched.

Comment 2

[Peter van der Woude [:Peter6]]

FWIW , the one hourly build that got all patches (before backout) consistently crashed when it started rendering content

Incident ID: 33030075
Stack Signature	_cairo_surface_composite_trapezoids cb6626a3
Product ID	FirefoxTrunk
Build ID	2007061004
Trigger Time	2007-06-11 08:40:49.0
Platform	Win32
Operating System	Windows NT 5.1 build 2600
Module	firefox.exe + (004ecd44)
URL visited	
User Comments	cairo 1.4.8 crashes on startup build 20070610_2009_firefox-3.0a6pre.en-US.win32
Since Last Crash	27 sec
Total Uptime	62216 sec
Trigger Reason	Access violation
Source File, Line No.	e:\builds\tinderbox\fx-trunk\winnt_5.2_depend\mozilla\gfx\cairo\cairo\src\cairo-surface.c, line 1410
Stack Trace 	
_cairo_surface_composite_trapezoids  [mozilla/gfx/cairo/cairo/src/cairo-surface.c, line 1410]
_cairo_output_stream_write  [mozilla/gfx/cairo/cairo/src/cairo-output-stream.c, line 183]
ntdll.dll + 0x106ab (0x7c9106ab)
0xffff9090

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

ugh, the stack on that crash is totally bogus... could be anything.

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Cairo 1.4.8 didn't land for a6; -> beta1

Comment 5

[Scott A.]

Wouldn't this be best to wait until late beta's? there could be a newer version than 1.4.8 by the time you upgrade to 1.4.8.

Comment 6

[Jesse Ruderman]

We can update cairo again in late beta if we want...

Comment 7

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

1.4.10 now

Comment 8

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

This bounced out of the tree again today, once again blocking on bug 384035 (which I erroneously thought was fixed).

Comment 9

[Michael Ventnor]

Can this be re-landed?

Comment 10

[Martijn Wargers (dead)]

It seems like this was landed at 2007-08-01 23:58, can this bug be marked FIXED?

Comment 11

[Oliver Saier]

Attachment: Screenshot showing the b0rkded Bookmarks menu

Comment 12

[Oliver Saier]

(In reply to comment #11)
> Created an attachment (id=275109) [details]
> Screenshot showing the b0rkded Bookmarks menu
> 

Sorry, I had many tabs open and attached to the wrong bug (was meant for  bug 390786).

Comment 13

[Frederic Bezies]

Related to new cairo version landing - bug 383960 ?

Comment 14

[Frederic Bezies]

Please, dismiss my previous comment, I think a crasher I see in Thunderbird is related to this patch. Sorry, a million times sorry for the spamming :(

Comment 15

[Frederic Bezies]

Is bug 390611 (a segmentation fault bug under linux x86_64) related to this cairo landing ?

Comment 16

[Andrew Smith]

Was this tested on Linux? Trunk builds stopped showing most webpages.

Regression range (this bug seems the most likely reason): http://bonsai.mozilla.org/cvsquery.cgi?&date=explicit&mindate=2007-08-01&maxdate=2007-08-02

Sorry if there's already a bug for that, I couldn't find it.

Comment 17

[m.]

(In reply to comment #16)
> Sorry if there's already a bug for that, I couldn't find it.
> 
bug 390786 ?

Comment 18

[Sylvain Fourmanoit]

(in reply to comment #16)

I haven't found a matching bug report either (bug 390786 seems different from mine), so I submitted one: see bug 392122. Feel free to comment if you think you experience this. 

Comment 19

[JD]

I believe this upgrade caused a bug that caused bugs #390786 and #390787 and it seems like they're kind of showstopping bugs that seem essential to fix.

Comment 20

[Jesse Ruderman]

Don't worry.  They're both marked as blocking1.9+ and they're both marked as blocking this bug (indicating that they're regressions from this bug).

Comment 21

[JD]

(In reply to comment #20)
> Don't worry.  They're both marked as blocking1.9+ and they're both marked as
> blocking this bug (indicating that they're regressions from this bug).
> 

Just asking, by that, you mean that those bugs MUST be fixed by Firefox 3 release or FF3 Betas?

Comment 22

[Jesse Ruderman]

Theoretically, yes.  In reality, blocking flags sometimes get changed, but this FIXED bug is the wrong place to complain about that :)