383583 - Because of natively styled form elements, select1 doesn't look right anymore

Status: RESOLVED WONTFIX

(Core Graveyard :: XForms, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

This is possibly linux only, or maybe mac too?
Testcase :http://mozilla.pettay.fi/moztests/xforms/nested_select1.xhtml

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

So styling of the select1 must be changed a bit.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: disable native styling for now

Aaron, could you test this on windows, using the classic and XP themes?

Comment 3

[aaronr]

(In reply to comment #2)
> Created an attachment (id=267566) [details]
> disable native styling for now
> 
> Aaron, could you test this on windows, using the classic and XP themes?
> 

Well, it works, if that is what you mean :-)  On classic your styling looked a little more appropriate since the comboboxes on classic have that heavy shading on the upper and left edges and the more subtle shading on the lower and right edges.  And the dropdown button is the same light gray as the system comboboxes.  So looked pretty much the same.  But on XP the system comboboxes look more like just a simple bluish-purple border with no shading and a bluish-purple color for the drop down button.  So with your patch the dropdown button has that same XP-type color, but the select1 still has the heavy shading like the classic, so looks a little 'different'.  Also with the XP theme the select1's shading along the bottom and right, on my machine at least, was almost such a light gray that it was almost not noticeable...almost blended in perfectly with the white so that the bottom and right borders looked like they weren't there.  If nothing else, that will probably need to be made a little darker.

Comment 4

[John L. Clark]

Attachment: Screenshot of select1 rendering on Windows

This screenshot shows that select1 elements cut off some of the text from the selected item.  This screenshot was taken on Windows XP using Firefox 3.0.3 and version 0.8.6ff3 of the Mozilla XForms Extension.

Comment 5

[John L. Clark]

Attachment: Screenshot of select1 rendering on Linux

This screenshot shows the issues with the rendering of select1 elements on Linux.   This behaviour is present in Firefox 3.0.3 on Ubuntu 8.10 using version 0.8.6ff3 of the Mozilla XForms Extension.

Comment 6

[Philipp Wagner [:imphil]]

Ah, a starting point of a patch is here:
https://bugzilla.mozilla.org/show_bug.cgi?id=457075
I wasn't able to confirm it on Mac yet, but there were some reports that it didn't help there.

Comment 7

[David Bolter [:davidb] (NeedInfo me for attention)]

RIP xforms