457075 - Double arrow on dropdown lists on Linux with Firefox 3

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[Philipp Wagner [:imphil]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.9.0.1) Gecko/2008070400 SUSE/3.0.1-0.1 Firefox/3.0.1
Build Identifier: 

The XForms extension creates its own dropdown lists. Firefox 3 uses native widgets (at least on Linux) for rendering dropdown lists and input boxes, and thus you get two arrows (one "system"-arrow which is without function and one working).
To prevent that from happening, native widgets need to be disabled. Please give it a try on Windows, as I'm currently not able to test it there. 

Reproducible: Always

Comment 1

[Philipp Wagner [:imphil]]

Attachment: testcase; try on Linux with Firefox 3

Comment 2

[Philipp Wagner [:imphil]]

Attachment: Patch

Comment 3

[Philipp Wagner [:imphil]]

Attachment: select1 widget before/after the patch

Comment 4

[Philipp Wagner [:imphil]]

Comment on attachment 340413 [details] [diff] [review]
Patch

patch tested on Windows Vista and Linux and it works.

Comment 5

[John L. Clark]

Note that Philipp Wagner pointed out that bug #383583 is similar to this bug.

Comment 6

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 340413 [details] [diff] [review]
Patch

Cancelling review since the reviewer has moved on. Please update the patch (if stale) and re-request review from someone else (if the bug is still valid). Please close if resolved.

Comment 7

[aaronr]

I can still do the review, but I was waiting until I heard that it worked on Mac.  All I can test on is Windows.

Please re-request review when it works on Mac.

Comment 8

[alexander :surkov (:asurkov)]

David, it's nice you keep an eye on XForms :)

Comment 9

[Philipp Wagner [:imphil]]

Can someone test on Mac, please? I don't have a mac either. Who does the mac builds?

Comment 10

[aaronr]

I actually have a snow leopard machine here at work, but I can't get cvs trunk to build on snow leopard (known issue mentioned in bug 477945).  If I can get the machine to build 1.9.1, I'll let you know.  Might be worth asking for a Mac build volunteer on the NG to test it.

Comment 11

[alexander :surkov (:asurkov)]

Attachment: mac screenshot

(In reply to comment #9)
> Can someone test on Mac, please? I don't have a mac either. Who does the mac
> builds?

There is no double arrow but it looks buggy - there is a empty space after dropdown arrow. But it's another bug I think.

Comment 12

[alexander :surkov (:asurkov)]

Attachment: mac screenshot (before patch)

Comment 13

[alexander :surkov (:asurkov)]

Comment on attachment 340413 [details] [diff] [review]
Patch

I think it's wrong to use -moz-appearance: none because XForms controls should have native UI style. But it's much better than two arrows, so I think it's worth to take this patch until we have something better.

Comment 14

[aaronr]

Comment on attachment 340413 [details] [diff] [review]
Patch

please open a bug on the mac combobox looking buggy.  with that, r=me

Comment 15

[alexander :surkov (:asurkov)]

I filed bug 560251 for this. Landed  -http://hg.mozilla.org/xforms/rev/ad4c3462bec5

Comment 16

[Sergey Reymerov]

I think this solution is ugly. Even drop down menus realisation is ugly. Drop down marker is unevenly placed. It is additional input element and so it looks like additional input element.

Comment 17

[alexander :surkov (:asurkov)]

(In reply to comment #16)
> I think this solution is ugly. Even drop down menus realisation is ugly. Drop
> down marker is unevenly placed. It is additional input element and so it looks
> like additional input element.

see my comment #13, feel free to file new bug and fix it :)