384304 - /usr/bin/firefox is not able to handle symlinks due to error in script

Status: RESOLVED FIXED

Description

[H. Montoliu]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.4) Gecko/20061201 Firefox/2.0.0.4 (Ubuntu-feisty)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.4) Gecko/20070601 Ubuntu/7.10 (gutsy) Firefox/2.0.0.4

If you call firefox through a symlink, e.g. /etc/alternatives/x-www-browser you get the error:

(gutsy_chroot)hjmf@paleo:/$ x-www-browser

run-mozilla.sh: Cannot execute /usr/lib/firefox/x-www-browser-bin.

The link in alternatives is OK:

(gutsy_chroot)hjmf@paleo:/$ ls -l /etc/alternatives/x-www-browser
lrwxrwxrwx 1 root root 16 Jun 11 14:06 /etc/alternatives/x-www-browser -> /usr/bin/firefox

After looking at /usr/bin/firefox script the error seems to be:  in the part that deals with symlinks, seems that somebody missed to pass back the resulting "$progbase" variable to the main process.

Possible patch can be:
--- /usr/bin/firefox	2007-06-13 15:37:26.000000000 +0200
+++ /usr/bin/firefox	2007-06-13 16:23:40.000000000 +0200
@@ -111,6 +111,7 @@
     bn=`basename "$progname"`
     cd `dirname "$progname"`
     progname=`/bin/ls -l "$bn" | sed -e 's/^.* -> //' `
+    progbase=`basename "$progname"`
     if [ ! -x "$progname" ]; then
       break
     fi





Reproducible: Always

Steps to Reproduce:
1. create a symlink to /usr/bin/firefox; e.g. ln -s ./foo /usr/bin/firefox
2. execute the symlink: ./foo
Actual Results:  
the error that raises is:
run-mozilla.sh: Cannot execute /usr/lib/firefox/foo-bin.

Expected Results:  
Should launch the browser as it was meant in the script

Comment 1

[H. Montoliu]

Created attachment 268232 [details] [diff] [review]
patch to /usr/bin/firefox shell script

Comment 2

[H. Montoliu]

Created attachment 268233 [details] [diff] [review]
The same patch but against ./browser/app/mozilla.in

This is for source MOZILLA_1_8_BRANCH -- last build I've made:

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.5pre) Gecko/20070607 BonEcho/2.0.0.5pre

Comment 3

[H. Montoliu]

Forgot to mention that this issue is dealt too at ubuntu's bug tracker:

https://bugs.launchpad.net/firefox/+bug/117575

Comment 4

[Alexander Sack]

confirmed.

Comment 5

[Benjamin Smedberg]

Comment on attachment 268233 [details] [diff] [review]
The same patch but against ./browser/app/mozilla.in

Chris, got time for this one? I'm a little lost in here

Comment 6

[Reed Loden [:reed] (use needinfo?)]

Note that Ubuntu has taken this patch downstream already (https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/117575).

Comment 7

[Reed Loden [:reed] (use needinfo?)]

Thanks for the patch!

Checking in browser/app/mozilla.in;
/cvsroot/mozilla/browser/app/mozilla.in,v  <--  mozilla.in
new revision: 1.16; previous revision: 1.15
done

Comment 8

[Daniel Veditz [:dveditz]]

Comment on attachment 268233 [details] [diff] [review]
The same patch but against ./browser/app/mozilla.in

approved for 1.8.1.10, a=dveditz for release-drivers

Comment 9

[Reed Loden [:reed] (use needinfo?)]

MOZILLA_1_8_BRANCH:

Checking in browser/app/mozilla.in;
/cvsroot/mozilla/browser/app/mozilla.in,v  <--  mozilla.in
new revision: 1.12.8.2; previous revision: 1.12.8.1
done

Comment 10

[Al Billings [:abillings]]

Verified for branch in Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.10) Gecko/2007111504 Firefox/2.0.0.10 (the RC1 for 2.0.0.10). I can reproduce this with 2.0.0.9 but not the 2.0.0.10 build.

Comment 11

[Reed Loden [:reed] (use needinfo?)]

Created attachment 295488 [details] [diff] [review]
patch mail, sunbird, and xulrunner, too!

asac noticed that this same change wasn't made to the three other mozilla.in files in the tree.

Comment 12

[Reed Loden [:reed] (use needinfo?)]

This is a blocker for Linux distros.

Comment 13

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 295488 [details] [diff] [review]
patch mail, sunbird, and xulrunner, too!

a=beltzner for 1.9

Comment 14

[Reed Loden [:reed] (use needinfo?)]

Checking in mail/app/mozilla.in;
/cvsroot/mozilla/mail/app/mozilla.in,v  <--  mozilla.in
new revision: 1.8; previous revision: 1.7
done
Checking in calendar/sunbird/app/mozilla.in;
/cvsroot/mozilla/calendar/sunbird/app/mozilla.in,v  <--  mozilla.in
new revision: 1.11; previous revision: 1.10
done
Checking in xulrunner/app/mozilla.in;
/cvsroot/mozilla/xulrunner/app/mozilla.in,v  <--  mozilla.in
new revision: 1.4; previous revision: 1.3
done

Comment 15

[Robert Kaiser]

Shouldn't have http://mxr.mozilla.org/mozilla/source/suite/app/seamonkey.in been patched as well?

Comment 16

[Reed Loden [:reed] (use needinfo?)]

(In reply to comment #15)
> Shouldn't have http://mxr.mozilla.org/mozilla/source/suite/app/seamonkey.in
> been patched as well?

It wasn't named mozilla.in, so I didn't find it. I blame SeaMonkey. :)

Comment 17

[Reed Loden [:reed] (use needinfo?)]

Created attachment 295904 [details] [diff] [review]
SeaMonkey patch

Just going to carry over r=cls since it's really just the same file as the others but in a different place.

KaiRo, can I get branch approval for this, too?

Comment 18

[Reed Loden [:reed] (use needinfo?)]

Checking in suite/app/seamonkey.in;
/cvsroot/mozilla/suite/app/seamonkey.in,v  <--  seamonkey.in
new revision: 1.3; previous revision: 1.2
done

Comment 19

[Robert Kaiser]

Comment on attachment 295904 [details] [diff] [review]
SeaMonkey patch

a-sm1.1.8=me for that SeaMonkey patch - but note that it's at mozilla/xpfe/bootstrap/mozilla.in on branch.

Comment 20

[Daniel Veditz [:dveditz]]

Not blocking, but we'll look at approvals.

Comment 21

[Reed Loden [:reed] (use needinfo?)]

Comment on attachment 295488 [details] [diff] [review]
patch mail, sunbird, and xulrunner, too!

Bug 411710 filed to track landing this on the 1.8 branch, as per request from drivers.

Comment 22

[Reed Loden [:reed] (use needinfo?)]

Checking in xpfe/bootstrap/mozilla.in;
/cvsroot/mozilla/xpfe/bootstrap/Attic/mozilla.in,v  <--  mozilla.in
new revision: 1.8.8.8; previous revision: 1.8.8.7
done