Created attachment 296363 [details] [diff] [review] 1.8 branch patch from bug 384304 +++ This bug was initially created as a useless clone of Bug #384304 +++ User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:18.104.22.168) Gecko/20061201 Firefox/22.214.171.124 (Ubuntu-feisty) Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:126.96.36.199) Gecko/20070601 Ubuntu/7.10 (gutsy) Firefox/188.8.131.52 If you call firefox through a symlink, e.g. /etc/alternatives/x-www-browser you get the error: (gutsy_chroot)hjmf@paleo:/$ x-www-browser run-mozilla.sh: Cannot execute /usr/lib/firefox/x-www-browser-bin. The link in alternatives is OK: (gutsy_chroot)hjmf@paleo:/$ ls -l /etc/alternatives/x-www-browser lrwxrwxrwx 1 root root 16 Jun 11 14:06 /etc/alternatives/x-www-browser -> /usr/bin/firefox After looking at /usr/bin/firefox script the error seems to be: in the part that deals with symlinks, seems that somebody missed to pass back the resulting "$progbase" variable to the main process. Possible patch can be: --- /usr/bin/firefox 2007-06-13 15:37:26.000000000 +0200 +++ /usr/bin/firefox 2007-06-13 16:23:40.000000000 +0200 @@ -111,6 +111,7 @@ bn=`basename "$progname"` cd `dirname "$progname"` progname=`/bin/ls -l "$bn" | sed -e 's/^.* -> //' ` + progbase=`basename "$progname"` if [ ! -x "$progname" ]; then break fi Reproducible: Always Steps to Reproduce: 1. create a symlink to /usr/bin/firefox; e.g. ln -s ./foo /usr/bin/firefox 2. execute the symlink: ./foo Actual Results: the error that raises is: run-mozilla.sh: Cannot execute /usr/lib/firefox/foo-bin. Expected Results: Should launch the browser as it was meant in the script
This is a blocker for Linux distros. The ones affected by it have already taken the patch themselves, so it's best to get it in our tree to help everybody.
Just curious: why are you excluding SeaMonkey here?
(In reply to comment #2) > Just curious: why are you excluding SeaMonkey here? Because I already landed the patch for SeaMonkey in bug 384304. :)
ah, sure, thanks. (I obviously approved it myself but got confused as I never actually saw the patch against the xpfe file :)
Comment on attachment 296363 [details] [diff] [review] 1.8 branch patch from bug 384304 approved for 184.108.40.206, a=dveditz for release-drivers
Checking in mail/app/mozilla.in; /cvsroot/mozilla/mail/app/mozilla.in,v <-- mozilla.in new revision: 220.127.116.11; previous revision: 18.104.22.168 done Checking in calendar/sunbird/app/mozilla.in; /cvsroot/mozilla/calendar/sunbird/app/mozilla.in,v <-- mozilla.in new revision: 22.214.171.124; previous revision: 126.96.36.199 done Checking in xulrunner/app/mozilla.in; /cvsroot/mozilla/xulrunner/app/mozilla.in,v <-- mozilla.in new revision: 188.8.131.52; previous revision: 184.108.40.206 done
Reed, can you verify this bug with the RC1 220.127.116.11 build?