384652 - "Firefox Updated" page incorrectly displayed on restore

Status: NEW

(Firefox :: Settings UI, defect)

Description

[cburroughs]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.4) Gecko/20070609 Firefox/2.0.0.4
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.4) Gecko/20070609 Firefox/2.0.0.4

After updating Firefox and running it for the first time it goes to a happy "Firefox Update" page (http://en-us.www.mozilla.com/en-US/firefox/2.0.0.4/whatsnew/).  If that tab is closed, the browsing session is continued, and then FF crashes the "Firefox Updated" page will open again.

Reproducible: Always

Steps to Reproduce:
1. Upgrade to the latest and greatest version.
2. Close the Welcome tab and continue browsing
3.  Kill/crash Firefox
4.  Restore previous session.
Actual Results:  
The Welcome page is displayed.

Expected Results:  
Not to be Welcomed.

Comment 1

[Simon Bünzli]

Attachment: flush the prefs after the milestone pref has been updated

Simple fix: write the pref responsible for this behavior to disk ASAP.

Not sure how many other prefs might be changed during startup. Might be worth always flushing the prefs when the first browser window loads instead of just treating this one pref in a special way.

Comment 2

[cburroughs]

This also applies for extensions that have a "hey we updated" message.

Comment 3

[Simon Bünzli]

Might indeed be worth delaying the pref flushing until delayedStartup of the first browser window (before which SessionStore won't kick in, anyway).

OTOH this is no SessionStore specific issue: if you don't restore at the 4. step in comment #0, you'll still get the "Firefox Updated" page another time (just not side-by-side with the restored one). -> Firefox:Preferences