Closed
Bug 384748
Opened 18 years ago
Closed 18 years ago
xpidl can generate garbage .java filenames
Categories
(Core Graveyard :: Java to XPCOM Bridge, defect)
Core Graveyard
Java to XPCOM Bridge
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ajschult784, Assigned: ajschult784)
References
Details
(Keywords: fixed1.8.1.8, Whiteboard: [needs testcase])
Attachments
(1 file)
|
873 bytes,
patch
|
jhpedemonte
:
review+
dveditz
:
approval1.8.1.8+
|
Details | Diff | Splinter Review |
xpidl_java's interface_declaration can construct the output file from an uninitialized char* if IDL filename has no '/'.
Attachment #268655 -
Flags: review?(jhpedemonte)
|
||
Updated•18 years ago
|
Attachment #268655 -
Flags: review?(jhpedemonte) → review+
|
Assignee | |
Comment 1•18 years ago
|
||
FIXED
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
|
||
Comment 3•18 years ago
|
||
Comment on attachment 268655 [details] [diff] [review]
patch
Asking for 1.8.1.7 approval. This is a low risk change that fixes a bug when using XPIDL to generate Java interface files.
Attachment #268655 -
Flags: approval1.8.1.7?
|
||
Comment 4•18 years ago
|
||
Sorry about the duplicate report.
As a minor comment, this code:
strcat(outname, interface_name);
strcat(outname, ".java");
may possibly overflow the outname buffer. My patch in bug 390705 tries to be more careful there.
|
||
Comment 5•18 years ago
|
||
Comment on attachment 268655 [details] [diff] [review]
patch
approved for 1.8.1.7, a=dveditz for release-drivers
Attachment #268655 -
Flags: approval1.8.1.7? → approval1.8.1.7+
|
|
Assignee | |
Updated•18 years ago
|
Keywords: fixed1.8.1.7
|
|
||
Updated•18 years ago
|
Whiteboard: [needs testcase]
|
||
Updated•11 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•