xpidl can generate garbage .java filenames

RESOLVED FIXED

Status

Core Graveyard
Java to XPCOM Bridge
RESOLVED FIXED
10 years ago
3 years ago

People

(Reporter: Andrew Schultz, Assigned: Andrew Schultz)

Tracking

({fixed1.8.1.8})

Trunk
fixed1.8.1.8

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [needs testcase])

Attachments

(1 attachment)

873 bytes, patch
jhp (no longer active)
: review+
Details | Diff | Splinter Review
(Assignee)

Description

10 years ago
Created attachment 268655 [details] [diff] [review]
patch

xpidl_java's interface_declaration can construct the output file from an uninitialized char* if IDL filename has no '/'.
Attachment #268655 - Flags: review?(jhpedemonte)

Updated

10 years ago
Attachment #268655 - Flags: review?(jhpedemonte) → review+
(Assignee)

Comment 1

10 years ago
FIXED
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Updated

10 years ago
Duplicate of this bug: 390705
Comment on attachment 268655 [details] [diff] [review]
patch

Asking for 1.8.1.7 approval.  This is a low risk change that fixes a bug when using XPIDL to generate Java interface files.
Attachment #268655 - Flags: approval1.8.1.7?

Comment 4

10 years ago
Sorry about the duplicate report.

As a minor comment, this code:

     strcat(outname, interface_name);
     strcat(outname, ".java");

may possibly overflow the outname buffer. My patch in bug 390705 tries to be more careful there.
Comment on attachment 268655 [details] [diff] [review]
patch

approved for 1.8.1.7, a=dveditz for release-drivers
Attachment #268655 - Flags: approval1.8.1.7? → approval1.8.1.7+
(Assignee)

Updated

10 years ago
Keywords: fixed1.8.1.7

Updated

10 years ago
Whiteboard: [needs testcase]
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.