38523 - L10n: Title of common dialogs aren't localizable

Status: VERIFIED FIXED

(Core :: Internationalization: Localization, defect, P2)

Description

[Fredrik Sundberg]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; m16) Gecko/20000507
BuildID:    2000050708

The following .js files contains common dialogs that has a title which can't be
translated:

Confirm messages [confirm()]:
profileManager.js
profileSelection.js
bookmarks.js
pref-charset.js
pref-languages.js
search-editor.js
nsSidebar.js
downloadProgress.js
filepicker.js
AccountManager.js

Alert messages [alert()]:
WalletEditor.js
createProfileWizard.js
profileManager.js
profileSelection.js
navigator.js
bm-props-js
finddialog.js
search-panel.js
nsSidebar.js
downloadProgress.js
addressbook.js
abMailListDialog.js
AccountManager.js
aw-identity.js
aw-done.js
aw-accname.js
aw-login.js
aw-server.js
importDialog.js

Prompt messages [prompt()]:
WalletEditor.js
ProfileManager.js
bookmarks.js
search-editor.js


Actual Results:  Title of dialogs appears in english in localized builds.

Expected Results:  Titles of dialogs should appear in the language of the
localization

Comment 1

[Blake Ross]

->localization

Comment 2

[Asa Dotzler [:asa]]

setting as NEW

Comment 3

[Joseph Elwell]

I have an identical bug in bugscape (bug 1315) that is nsbeta2+ but only
specific to aim.

Comment 4

[Blake Ross]

I'll do this, but [e-mail], any chance you can provide an up-
to-date list of files still needing changes?  As your list is from 5/8, I fear 
some files may have since been fixed/changed. Thanks.

Comment 5

[Joseph Elwell]

blake: I think the files listed are not places that fixes actually need to be
made. instead, these files are places where a common dialog is being called,
such as window.confirm(). AFAIK window.confirm() takes a single string, the
description - which in most cases has been localized (possibly all). The problem
is window.confirm() and others don't have an option to change the title, and
their default title is not localized.

Comment 6

[Blake Ross]

Joseph explained to me what had to be done here, I was a little confused 
earlier.  Basically, then, this needs to be changed in the cpp code.  
Reassigning back to the l10n owner for now, can someone point me in the 
direction where JS confirms are handled?

Comment 7

[Joseph Elwell]

found the code (nice comment next to it, points out that it's not localizable)
http://lxr.mozilla.org/seamonkey/source/xpfe/appshell/src/nsWebShellWindow.cpp#1832
and elsewhere in that file: look for //XXX i18n

Comment 8

[Blake Ross]

The problem is in nsWebShellWindow.cpp, lines 1817 and 1832.  those are 
warren's lines...

Comment 9

[Blake Ross]

reassign

Comment 10

[leger]

Putting on [nsbeta2+] radar.

Comment 11

[Warren Harris]

I just moved the code, I didn't originate this bug, and I don't own 
nsICommonDialogs.

Comment 12

[Joseph Elwell]

I need an ETA for this bug.

Comment 13

[rchen]

Reassigned to Don. 

Don, this should be in your area, right? I think this is a duplicated bug.

Comment 14

[don]

Removing "nsbeta2+" ro re-consideration.  We can ship without this.

Comment 15

[Joseph Elwell]

I agree, we can ship without this. My bugscape bug is also being considered for
cuttage.

Comment 16

[Viswanath Ramachandran]

don if you dont mind - I'll just go ahead and mark this nsbeta2- so that PDT 
doesnt have to go through it again. I think we agreed in the leads meeting that 
it was ok for owning engg mgrs to mark it minus, anyone on the cc list not 
agreeing - please scream. Vishy

Comment 17

[Chris McAfee]

This can't get pushed back forever, m18.

Comment 18

[don]

Well, it can be pushed out of beta 2. :-)

Nominating for beta 3.

Comment 19

[Claudius Gayle]

nav triage team: [b3nav+] now = [nsbeta3+]

Comment 20

[Joseph Elwell]

Ben: if you haven't done any work on this, then assign it for me, as I am trying
to solve this. Thanks.

Comment 21

[Ben Goodger (use ben at mozilla dot org for email)]

if you like ;) 

the fun starts around here:
http://lxr.mozilla.org/seamonkey/source/xpfe/appshell/src/nsWebShellWindow.cpp#1
735

looks like you just need to make this code use stringbundles instead. 

Comment 22

[Joseph Elwell]

Alright, I'm all over this, I've already been testing a String Bundle addition
to that file. cool. Thanks Ben.

Comment 23

[Daniel Veditz [:dveditz]]

Adding nsbeta2 keyword to bugs with nsbeta2 triage value in status field so the 
queries don't get screwed up

Comment 24

[Joseph Elwell]

Attachment: patch.

Comment 25

[Joseph Elwell]

reassigning back. that was fun.
Ben: hopefully this patch helps. It works on my machine. Although I don't know 
if creating a new string bundle in each function is a great idea. maybe a 
stringbundle needs to be a member?

Comment 26

[Joseph Elwell]

I forgot to mention, with the patch a webShellWindow.properties file needs to be 
created that looks like this:

Alert=Alert
Confirm=Confirm
...

Comment 27

[Ben Goodger (use ben at mozilla dot org for email)]

Joseph: a couple of problems with your patch. 

1) You changed the control flow to only show the dialog when dialogTitle was not 
supplied.

2) You did not free the strings you retrieved from the bundle. 

I've checked in a modified version of your patch that resolves these issues.

Thanks!

Comment 28

[Blake Ross]

See bug 51569, which I think the fix for this caused (possible solution posted 
there)...

Comment 29

[msanz]

Assigning to Tao for verification

Comment 30

[tao]

.

Comment 31

[tao]

w/ 
http://lxr.mozilla.org/seamonkey/source/xpfe/appshell/src/nsWebShellWindow.cpp#1
864