Closed Bug 385385 Opened 17 years ago Closed 17 years ago

in-product links to AMO should be https:// (and not http://)

Categories

(Thunderbird :: General, defect)

Product:
Thunderbird
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: moco, Assigned: philor)

Details

(Keywords: verified1.8.1.5, Whiteboard: [sg:want P3])

Attachments

(1 file)

Fix
1.67 KB, patch
mscott
: review+
dveditz
: approval1.8.1.5+
Details | Diff | Splinter Review 
in-product links to AMO should be https:// (and not http://) (edit)

/mail/app/profile/all-thunderbird.js, 
line 132 -- pref("extensions.getMoreExtensionsURL",
"http://%LOCALE%.add-ons.mozilla.com/%LOCALE%/%APP%/%VERSION%/extensions/");
line 133 -- pref("extensions.getMoreThemesURL",
"http://%LOCALE%.add-ons.mozilla.com/%LOCALE%/%APP%/%VERSION%/themes/");

see bug #384897 for details.
Flags: blocking1.8.1.5?
Flags: blocking-thunderbird3?
Flags: blocking-thunderbird2?
Whiteboard: [sg:want P3]
Attached patch Fix — — Splinter Review 
No need for 1.8.0, where it's a toolkit/locale issue for the few locales that aren't https, and only one line of offset for 1.8.1. The world needs more simple things like this.
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
Attachment #269326 - Flags: review?(mscott)
Attachment #269326 - Flags: approval1.8.1.5?
Comment on attachment 269326 [details] [diff] [review]
Fix

thanks Phil!
Attachment #269326 - Flags: review?(mscott) → review+
mail/app/profile/all-thunderbird.js 1.93
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
OS: Windows XP → All
Hardware: PC → All
Resolution: --- → FIXED
Summary: in-product links to AMO should be https:// (and not http://) (edit) → in-product links to AMO should be https:// (and not http://)
Flags: blocking1.8.1.5? → blocking1.8.1.5+
Comment on attachment 269326 [details] [diff] [review]
Fix

approved for 1.8.1.5, a=dveditz for release-drivers
Attachment #269326 - Flags: approval1.8.1.5? → approval1.8.1.5+
mail/app/profile/all-thunderbird.js 1.44.2.46
Flags: blocking-thunderbird2?
Keywords: fixed1.8.1.5
verified fixed 1.8.1.5 using Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.5pre) Gecko/20070703 Thunderbird/2.0.0.5pre Mnenhy/0.7.5.0 ID:2007070406 the in-product links to AMO are now https://...  - adding verified keyword
Keywords: fixed1.8.1.5 → verified1.8.1.5
Status: RESOLVED → VERIFIED
Flags: blocking-thunderbird3?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: