385408 - Bookmarks toolbar context menu sometimes becomes entirely disabled

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect)

Description

[Rob Arnold [:robarnold]]

I have yet to find a reproducible test case, but it has happened twice today in separate occasions (and separate sessions).

Comment 1

[Marcia Knous [:marcia]]

Rob: I have seen this as well on yesterday's build, although I can't recall whether I saw it on Vista or the Mac. I could not easily reproduce it but I will keep an eye out today.

Comment 2

[Wayne Woods]

I've noticed this a number of times lately, on Windows XP (never observed on my Mac, even though I use it frequently).

I can't find a way to reproduce reliably yet, so I can't pinpoint the regression date. But it seems to have been within the past 3 months.

Comment 3

[Wayne Woods]

I found a reliable way to reproduce, though it's fiddly and it's not going to be the only way. These steps have to be followed almost precisely:
1. open a fresh browser window
2. hit ctrl-t twice in a row to open two more tabs (once will not do, and must be done in succession)
3. right click on bookmarks bar (menu is active, but this step is important)
4. hit ctrl-w once to close one tab (clicking the close button won't do)
5. right click on the bookmarks bar again (should be disabled)

Using this method, I discovered that the regression range was between the 20070518-04 and 20070518-21 trunk nightlies, i.e. when places bookmarks were switched on. To determine when the bug was actually introduced, we'd probably have to test out older places-enabled builds.

Comment 4

[Wayne Woods]

Also of note:
- Can reproduce on Mac
- Using the STR I mentioned in comment 3, the context menu only seems to be disabled for the first context click. A second click reenables it. However I've frequently been in situations where the context menu was disabled indefinitely and I've had to close the window to get it back. So there must be other, better ways of reproducing this.

Comment 5

[Wayne Woods]

Curious. This bug regressed on Mac 12 days after Windows.

The regression time on Mac is 20070530 between 11:00 and 12:00 PDT. According to Bonsai, this can only be due to the Cocoa-specific check-in for bug 373122 (which is restricted.. I can't read it):
http://bonsai.mozilla.org/cvsquery.cgi?module=SeaMonkeyBrowser&branch=HEAD&date=explicit&mindate=20070530+11%3A00%3A00&maxdate=20070530+12%3A00%3A00

Steven (and/or Josh), do you have any idea why that check-in might have caused this bug on Mac? Hopefully it'll give some insight into the Windows fix as well. Thanks!

Comment 6

[Steven Michaud [:smichaud] (Retired)]

(In reply to comment #5)

I'll get to this as soon as I can ... I hope sometime this week.

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

wrt the Mac, see bug 381477; comment 4 seems to be describing exactly that bug, if I understand the comment correctly.

Comment 8

[Steven Michaud [:smichaud] (Retired)]

Thanks for the hint, Smokey!

I'm not sure this is a dup of bug 381477.  But both bug 381477 and
this bug (bug 385408) are fixed (on the Mac at least) by my patch for
bug 389542.

I haven't (yet) tested whether my patch for bug 373122 actually
triggered this bug.  That patch caused NSView objects (those
associated with nsChildView objects) to be dealloced asynchronously.
And since bug 389542 was triggered by the patch for bug 279703, which
started hiding popup windows asynchronously, the connection is
plausible.

But since the patch for bug 389542 fixes this bug, I don't have to
worry about altering my patch for bug 373122.

Comment 9

[Steven Michaud [:smichaud] (Retired)]

I've now absolved my bug 373122 patch from any blame for this bug:

I backed out my fix for bug 389542 and my bug 373122 patch -- but this
didn't cause the bug to start happening again.

Comment 10

[Steven Michaud [:smichaud] (Retired)]

> I've now absolved my bug 373122 patch from any blame for this bug:
>
> I backed out my fix for bug 389542 and my bug 373122 patch -- but
> this didn't cause the bug to start happening again.

Sigh, faulty logic.

I've been working on too many bugs at once :-(

Comment 11

[Steven Michaud [:smichaud] (Retired)]

It appears that my bug 373122 patch _did_ trigger this bug (on the
Mac).

But again, since my patch for bug 389542 also fixes this bug, I don't
think I need to alter my bug 373122 patch.  (And we can't back it out,
since it fixes a very serious problem.)

Comment 12

[Steven Michaud [:smichaud] (Retired)]

Fixed by patch for bug 389542, which just landed on trunk.

Comment 13

[Wayne Woods]

(In reply to comment #12)
> Fixed by patch for bug 389542, which just landed on trunk.

Will that fix the problem only on the Mac?

Comment 14

[Steven Michaud [:smichaud] (Retired)]

>> Fixed by patch for bug 389542, which just landed on trunk.
>
> Will that fix the problem only on the Mac?

Oops, sorry.  You're right.  I got carried away :-)

Comment 15

[Wayne Woods]

Heheh :) Is there anything in what you did that might suggest what's wrong on other platforms?

Comment 16

[Steven Michaud [:smichaud] (Retired)]

> Is there anything in what you did that might suggest what's wrong on
> other platforms?

There's nothing that stands out ... at least that I can see.

Do look at comment #8, though.

Comment 17

[Brian Polidoro]

Could this have been two separate problems with the same symptom?  (1 Windows problem & 1 Mac problem) I did see this on Windows.  But I found it was due to a focus problem which has been resolved.  The workaround for the focus problem corrected this context menu problem when I encountered it.  

It would also explain this:
> Curious. This bug regressed on Mac 12 days after Windows.

Comment 18

[Mike Connor [:mconnor]]

WFM now?  adding qawanted

Comment 19

[Marcia Knous [:marcia]]

using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre) Gecko/2007101005 Minefield/3.0a9pre, I am not able to repro this using steps in Comment 3. I will check on Mac next.

Comment 20

[Mike Connor [:mconnor]]

clearing blocking, please renominate if this can still be reproduced.

Comment 21

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv