386099 - when drag leaves places-based personal toolbar, clear the drop indicator

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect, P4)

Description

[(not reading, please use [e-mail] instead)]

when drag leaves places based personal toolbar, clear the drop indicator

steps to reproduce:

1) from the url bar, drag the favicon.
2) when you drag over the personal toolbar, you'll get the drop indicator (it's currently ugly and purple, see bug #382893)
3) continue dragging and leave the personal toolbar area.

expected results:  the drop indicator disappears when you drag out.
actual results:  the drop indicator is not cleared, and remains.

I see this on Windows, Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a6pre) Gecko/2007062612 Minefield/3.0a6pre

christine, do you see it on mac?

Comment 1

[Wayne Woods]

Yeah, it's Mac too (though my name's not Christine ;) )

onDragExit is calling a timer to turn off the drag indicator:
http://mxr.mozilla.org/seamonkey/source/browser/components/places/content/toolbar.xml#823

I can confirm that it gets that far, at least, but it doesn't seem to be working for some reason. I haven't investigated why, yet.

As explained in the code, it uses a delay-timer to avoid the flicker effect of the indicator being switched off every time it exits one element even if it's passing into another bookmarks toolbar element.

However in tabs, we just check if the new location is also a valid part of the tab bar and don't switch off the indicator if it is (bug 333791). Is there any reason we couldn't scrap the timer and go with that approach for the bookmarks toolbar? I'm sure I could get a patch together quickly...

Comment 2

[Wayne Woods]

Attachment: Patch v1

This works by simply switching off the indicator in onDragExit, rather than using a timer. It adds checks similar to the tab dnd code in order to avoid flicker. I built and tested it on Mac, but temporarily added favicons to the toolbar to test out how it'd behave over other elements.

Comment 3

[Wayne Woods]

Seems to have been fixed between 20070919 and 20070920, at least on Mac. Need to confirm at least with Windows first...

Comment 5

[Dietrich Ayala (:dietrich)]

yep, i can't reproduce either.

Comment 6

[Tracy Walker [:tracy]]

This does work on Mac, but is still broken on Win XP. Once a drag has passed over the BT, the indicator remains present, no matter where the mouse goes, until the drop is complete.

Comment 7

[(not reading, please use [e-mail] instead)]

I still see this on windows xp, as well.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre) Gecko/2007101704 Minefield/3.0a9pre

Comment 8

[Wayne Woods]

I assume the timer code still needs to be fixed on XP?

Anyway, even if it is fixed, wouldn't it be better to go with the "tab dnd" method of checking if it's over the bookmarks bar and scrapping the timer use, as done in this patch? Anyone want to make a call on that? :)

Comment 12

[Dietrich Ayala (:dietrich)]

Wayne, sorry for the delay in looking at this. Can you verify that the patch is not rotted, and I'll review asap.

Comment 13

[Wayne Woods]

No worries on the delay. Shortly after I posted my home computer died and I still have nothing to build on. Hoping the situation will be rectified within the next couple of weeks and then I'll get back to you :)

Comment 14

[Mike Connor [:mconnor]]

Not going to continue to block on this.  If you disagree with this decision, please renominate with reasons why we can't ship with this in final

Comment 15

[Dão Gottwald [:dao]]

Has this been fixed by bug 389931?

Comment 16

[Marco Bonardo [:mak]]

WFM
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008042606 Minefield/3.0pre

Comment 17

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv