386158 - Sending receipt fails but no warning returns to user

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[lijuan wang]

Reproduced steps:

You'll need two mail accounts to test this. The 1st mail account can both send and receive mails successfully, while the 2nd mail account can only receive mails because of the uncorrect configuration of its smtp server.

1. Send a mail from 2nd mail account to 1st one.
2. In the 1st mail account, Account settings->Return Receipts, make sure you have turned ON "When sending messages, always request a return receipt." 
3. In the 2nd mail account, go to Account settings->Return Receipts
4. In the section for "When I receive a request for a return receipt" select the radio button for "Allow return receipts for some messages." 
5. For all of the corresponding droplists, select "Ask me." 
6. Hit OK, OK/Close to save your changes and dismiss the Prefs. 
7. Send email from the 1st mail account to 2nd one
8. From the 2nd mail account, read that message and allow the return receipt to be sent to the 1st mail account. 

Actual results:
After step#1: Pop out a Warning dialog as "Send Message Error",Sending of message failed. An error occurred sending mail: Unable to connect to SMTP server..........

After step#8:No warning dialog and 1st mail account didn't receive the reciept from 2nd mail account.The user will consider that he has sent the receipt successfully.

Expected results:
After step#8: Pop out the similar warning dialog as the result of step#1.The user will know that he fails to send out the receipt.

Comment 1

[emily chen]

Not only a Solaris bug, but exist on all platform. 

Comment 2

[Boying Lu]

Attachment: patch

Comment 3

[Ginn Chen]

The last 2 rv assignments are never used after.

We can use
if (dialog)
instead of 
if (NS_SUCCEEDED(rv))

Comment 4

[Boying Lu]

Attachment: patch

Comment 5

[David :Bienvenu]

Comment on attachment 327371 [details] [diff] [review]
patch

This looks good; However, I looked at MsgMdnFailed=A failure occurred. A proper return receipt could not be generated or sent to you.

and I believe that text is a little wrong - the return receipt isn't sent "to you". It's sent "from you" or "on your behalf" or just "sent." :-)

If it's because of an account configuration issue, we might want to indicate that in the error message as well.

Comment 6

[Boying Lu]

(In reply to comment #5)
> (From update of attachment 327371 [details] [diff] [review])
> This looks good; However, I looked at MsgMdnFailed=A failure occurred. A proper
> return receipt could not be generated or sent to you.
> 
> and I believe that text is a little wrong - the return receipt isn't sent "to
> you". It's sent "from you" or "on your behalf" or just "sent." :-)
> 
> If it's because of an account configuration issue, we might want to indicate
> that in the error message as well.
> 
I didn't use "MsgMdnFailed" in my patch,I use MsgMdnFailedReceipt instead which is "Return Receipt (failed)". Though it is not accurate error message, it's the most proper message I could find  

Comment 7

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 327371 [details] [diff] [review]
patch

If we're bothering to fix this, we should give it a useful error message.  If this means adding another error message, so be it.

Comment 8

[Boying Lu]

Attachment: new patch

Display more useful error message

Comment 9

[David :Bienvenu]

Comment on attachment 327756 [details] [diff] [review]
new patch

thx for the patch. It would be nice if the smtp service provided this capability, but it doesn't look trivial to carve out the code...

Comment 10

[Magnus Melin [:mkmelin]]

The indention of the middle block is a space off.

Comment 11

[Boying Lu]

Attachment: remove extra space

Comment 12

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 328625 [details] [diff] [review]
remove extra space

sr=dmose; thanks for the patch.

Comment 13

[Ginn Chen]

It's not fixed yet, if checkin-needed.

Comment 14

[Mark Banner (:standard8)]

Checking in mailnews/extensions/mdn/src/nsMsgMdnGenerator.cpp;
/cvsroot/mozilla/mailnews/extensions/mdn/src/nsMsgMdnGenerator.cpp,v  <--  nsMsgMdnGenerator.cpp
new revision: 1.35; previous revision: 1.34
done