SeaMonkey only: no "view cert button" in untrusted cert error dialog

RESOLVED FIXED in seamonkey2.0a1

Status

SeaMonkey
Security
--
critical
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: kaie, Assigned: stefanh)

Tracking

({regression})

Trunk
seamonkey2.0a1
regression

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

1006 bytes, patch
neil@parkwaycc.co.uk
: review+
neil@parkwaycc.co.uk
: superreview+
Details | Diff | Splinter Review
(Reporter)

Description

10 years ago
Go to an untrusted site, like https://www.cacert.org
You will get a message saying the cert is untrusted (as expected).

Problem: The dialog does not offer a "view cert" button.

This button is present in SeaMonkey 1.1, Firefox trunk, etc.
It appears, this is a regression in SeaMonkey trunk only.
Dan, please mark this bug so that the security group will take notice of it.
Severity: normal → critical
Flags: blocking-seamonkey2.0a1?

Comment 2

10 years ago
This is actually a regression from bug 344243 - our help button overlay accidentally removed the View Cert button. Note that the original bug 343395 got this right. I also didn't find any other dialogs missing the extra2 button.
Blocks: 344243
(Assignee)

Comment 3

10 years ago
The extra2 button seems to have been added in bug 343253 some weeks after bug 343395 was resolved.
(Assignee)

Comment 4

10 years ago
Created attachment 270773 [details] [diff] [review]
One-liner, add extra2 button
Assignee: dveditz → stefanh
Status: NEW → ASSIGNED
Attachment #270773 - Flags: superreview?(neil)
Attachment #270773 - Flags: review?(neil)

Comment 5

10 years ago
Comment on attachment 270773 [details] [diff] [review]
One-liner, add extra2 button

r+sr=me by code inspection.
Attachment #270773 - Flags: superreview?(neil)
Attachment #270773 - Flags: superreview+
Attachment #270773 - Flags: review?(neil)
Attachment #270773 - Flags: review+
(Assignee)

Comment 6

10 years ago
Checking in suite/common/helpSecurityOverlay.xul;
/cvsroot/mozilla/suite/common/helpSecurityOverlay.xul,v  <--  helpSecurityOverlay.xul
new revision: 1.2; previous revision: 1.1
done
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
(Assignee)

Updated

10 years ago
Flags: blocking-seamonkey2.0a1?
Target Milestone: --- → seamonkey2.0alpha
You need to log in before you can comment on or make changes to this bug.