Closed Bug 386281 Opened 15 years ago Closed 15 years ago

"Type Manifest File:" spewed to console on launch.

Categories

(Core :: XPCOM, defect)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED

People

(Reporter: Dolske, Assigned: Dolske)

References

Details

Attachments

(1 file, 1 obsolete file)

 
Attached patch Remove printf (obsolete) — Splinter Review
(doh)

Every time I launch Minefield, one of the first lines logged to console is:

Type Manifest File: /Users/dolske/[...profile path...]/xpti.dat

It's just one line, but lots of low-value just-one-lines are causing a lot of unneeded console spewage.
Attachment #270273 - Flags: review?(dougt)
Is this the very first line normally? I actually find it quite useful as it tells me which profile the app is starting up with (or even where it is if its a new profile) - which is very useful when you're trying to sort out profile migration and selection issues.

Anyway if you are going to get rid of it, you might as well just get rid of the whole ifdef.
Blocks: fx-noise
(In reply to comment #2)
> Is this the very first line normally? I actually find it quite useful as it
> tells me which profile the app is starting up with

I'm seeing it often with my builds, at least.

If we had common problems with things starting up with the wrong profile, then it would make sense to leave it in by default. But "this is sometimes useful" otherwise results in the mass console spewage we have today. :(

> Anyway if you are going to get rid of it, you might as well just get rid of the
> whole ifdef.

Oh, good point. Heh!
Comment on attachment 270273 [details] [diff] [review]
Remove printf

it is a debug build, but i suppose that the location of the xpt file is a well know location.

agreed.
Attachment #270273 - Flags: review?(dougt) → review+
The previous r+ can probably carryover, but might as well be conservative. :)
Attachment #270273 - Attachment is obsolete: true
Attachment #270381 - Flags: review?(dougt)
Comment on attachment 270381 [details] [diff] [review]
Remove the whole #ifdef

yeah, i guess I should have looked at where shown was being used...
Attachment #270381 - Flags: review?(dougt) → review+
Attachment #270381 - Flags: superreview?(benjamin)
Attachment #270381 - Flags: superreview?(benjamin) → superreview+
Checking in xpcom/reflect/xptinfo/src/xptiManifest.cpp;
/cvsroot/mozilla/xpcom/reflect/xptinfo/src/xptiManifest.cpp,v  <--  xptiManifest.cpp
new revision: 1.32; previous revision: 1.31
done
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.