386287 - inconsistent use of title / name in bookmarks UI

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[(not reading, please use [e-mail] instead)]

inconsistent use of title / name in bookmarks UI

Name: (in bookmark properties dialog, add bm dialog)
Sort By Name (in context menu)
View | Sort By Title
Title column in bm manager

Not really the same, but:  Reload Live Title (in context menu) and "Live Titles" in properties dialog.

This was pointed out in bug #262329

Comment 1

[Steve Won (stevewon on irc)]

Attachment: Patch

Comment 2

[Michael Wu [:mwu]]

Checking in browser/locales/en-US/chrome/browser/places/places.dtd;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/places/places.dtd,v  <--  places.dtd
new revision: 1.26; previous revision: 1.25
done
Checking in browser/locales/en-US/chrome/browser/places/places.properties;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/places/places.properties,v  <--  places.properties
new revision: 1.21; previous revision: 1.20
done

Comment 3

[Tracy Walker [:tracy]]

verified with: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007072505 Minefield/3.0a7pre; everything is using Name.

Comment 4

[Marek Stępień [:marcoos, inactive]]

 <!ENTITY col.title.label
-  "Title">
+  "Name">

This is a semantic change which means you should change the entity name as well. Same thing in the .properties file.

Ccing Axel.

Comment 5

[Axel Hecht [:Pike]]

Reopening, the entities should really be called col.name.label and view.sortBy.name. The accesskey for "Sort by Name" is broken, too, both entity name and value should be fixed.

Comment 6

[Mike Connor [:mconnor]]

Missing the freeze, moving out.

Comment 7

[Dietrich Ayala (:dietrich)]

oops, still targeting M8

Comment 8

[(not reading, please use [e-mail] instead)]

taking, I'll fix this along with bug #393868 since I'm in that file anyways.

Comment 9

[(not reading, please use [e-mail] instead)]

Attachment: patch

includes fix for bug #393879 and bug #393868

Comment 10

[(not reading, please use [e-mail] instead)]

the reason I added the code to map title to name (when getting the label and access key) is so that by keeping the same id (of "title"), we would keep the persisted ordinal value (so that it stays as the first column, for exisitng problems).

Comment 11

[(not reading, please use [e-mail] instead)]

Attachment: updated patch (removed the fix for bug #393879)

Comment 12

[(not reading, please use [e-mail] instead)]

Attachment: updated patch

excludes the fixes for bug #393879 and bug #393868 (which have already landed)

Comment 13

[(not reading, please use [e-mail] instead)]

Attachment: updated patch

sorry for the thrashing.

Comment 14

[Asaf Romano (gone)]

Comment on attachment 278469 [details] [diff] [review]
updated patch

r=mano

Comment 15

[(not reading, please use [e-mail] instead)]

logged code cleanup bug #393939, after discussing with asaf over irc.

but this bug is fixed.

Checking in browser/components/places/content/places.js;
/cvsroot/mozilla/browser/components/places/content/places.js,v  <--  places.js
new revision: 1.98; previous revision: 1.97
done
Checking in browser/components/places/content/places.xul;
/cvsroot/mozilla/browser/components/places/content/places.xul,v  <--  places.xul

new revision: 1.79; previous revision: 1.78
done
Checking in browser/locales/en-US/chrome/browser/places/places.dtd;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/places/places.dtd,v  <--
places.dtd
new revision: 1.28; previous revision: 1.27
done
Checking in browser/locales/en-US/chrome/browser/places/places.properties;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/places/places.properties,v
  <--  places.properties
new revision: 1.25; previous revision: 1.24
done

Comment 16

[Carsten Book [:Tomcat]]

verified using Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9b3pre) Gecko/2008010805 Minefield/3.0b3pre ID:2008010805 everything is using Name.

Comment 17

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv