393879 - "view | show columns | name" is not disabled

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[(not reading, please use [e-mail] instead)]

"view | show columns | name" is not disabled

the problem is:

        // Cannot uncheck the primary column.
        if (column.primary)
          menuitem.setAttribute("disabled", "true");

we should be doing:

        // Cannot uncheck the primary column.
        if (column.getAttribute("primary") == "true")
          menuitem.setAttribute("disabled", "true");

fix included with a patch for bug #386287

Comment 1

[(not reading, please use [e-mail] instead)]

looking at http://lxr.mozilla.org/seamonkey/source/toolkit/content/widgets/tree.xml#704, it appears that .primary is supposed to work.

Comment 2

[(not reading, please use [e-mail] instead)]

note, if you do "View | show columns | name", we'll hide the column in the left hand pane of the bookmark organizer, which has an id of "title" as well.

this looks to be a regression from bug #366594, where mano switched from:

-        if (column.getAttribute("primary") == "true")
+        if (column.primary)
           menuitem.setAttribute("disabled", "true");
         // Items for visible columns are checked. 
-        if (column.getAttribute("hidden") != "true")
+        if (column.hidden)

column is a XULElement, so .hidden works, but primary is a readonly attribute on nsITreeColumn, so it fails because we are doing:

var column = columns.getColumnAt(i).element;

I'll attach a patch for mano to review.

Comment 3

[(not reading, please use [e-mail] instead)]

Attachment: patch

Comment 4

[Asaf Romano (gone)]

Comment on attachment 278464 [details] [diff] [review]
patch

r=mano

Comment 5

[(not reading, please use [e-mail] instead)]

fixed

Checking in browser/components/places/content/places.js;
/cvsroot/mozilla/browser/components/places/content/places.js,v  <--  places.js
new revision: 1.97; previous revision: 1.96
done

Comment 6

[Tracy Walker [:tracy]]

verified with - Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a8pre) Gecko/2007091304 Minefield/3.0a8pre

Comment 7

[Aakash Desai [:aakashd]]

Test cases were updated on litmus to reflect regression testing.

For 3.0,
https://litmus.mozilla.org/show_test.cgi?id=4454

For 3.1,
https://litmus.mozilla.org/show_test.cgi?id=6394

Comment 8

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv