386772 - datepicker should use iso format for dates

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Neil Deakin]

Currently yyyy/mm/dd is used, but yyyy-mm-dd should be used

Comment 1

[Neil Deakin]

Attachment: change to use hyphens as separators

Also includes general datepicker/timepicker testcases.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 270809 [details] [diff] [review]
change to use hyphens as separators

>Index: toolkit/content/tests/widgets/test_datepicker.xul
>Index: toolkit/content/tests/widgets/test_timepicker.xul

These comments apply to both files:

>+  var setTimeField = function(field, value, expectException,
>+                              expectedHour, expectedMinute, expectedSecond)

nit: Use function setTimeField() {} here, that way the function object has a name for debugging purposes.

>+function testtag_comparetime(tp, testid, hour, minute, second)
>+{

>+  is(dateValue.getHours() == hour &&
>+                dateValue.getMinutes() == minute &&
>+                dateValue.getSeconds() == second,
>+                true, testid + " dateValue");

nit: Use ok() here?

Comment 3

[:Gavin Sharp [email: [e-mail]]]

I had to disable the tests added here because they were causing trouble on the windows unit test box. See bug 389616.

Comment 4

[mcdavis941 (sporadically reading bugmail)]

(In reply to comment #1)
> Created an attachment (id=270809) [details]
> change to use hyphens as separators
> 
> Also includes general datepicker/timepicker testcases.
> 

For the record, it looks like this patch changes not just the way the datepicker's displayed but also the format of the contents of the "value" attribute and "value" property.

Comment 5

[Neil Deakin]

This patch changes the value property/attribute to use '-' instead of '/'. It doesn't change the displayed value at all.