386866 - toolkit/xre/Makefile.in install:: target broken on trunk

Status: RESOLVED FIXED

Description

[Alexander Sack]

Created attachment 270920 [details] [diff] [review]
install platform.ini

checkin

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/toolkit/xre&command=DIFF_FRAMESET&file=Makefile.in&rev1=1.79&rev2=1.80&root=/cvsroot

breaks make install.

Comment 1

[walter sheets]

I've noticed that I need to copy application.ini as well as
platform.ini to the target directory.  Have you seen this?

Also, 'make install' generate an extra step which should not
be there:
/usr/src/tb/mozilla/obj/config/nsinstall -R -m 644  /usr/local/lib/thunderbird-3.0a1pre

No file is named in that line, which is a syntax error. I've
been trying to find the source of that extra line, but so 
far I'm defeated.  Have you seen this error?

Thanks.

Comment 2

[Alexander Sack]

(In reply to comment #1)
> I've noticed that I need to copy application.ini as well as
> platform.ini to the target directory.  Have you seen this?

platform.ini will be installed by this patch.

for application.ini i have prepared a patch against config/rules.mk which I will open a new bug for once my tests succeed.

Comment 3

[Alexander Sack]

(In reply to comment #1)
> Also, 'make install' generate an extra step which should not
> be there:
> /usr/src/tb/mozilla/obj/config/nsinstall -R -m 644 
> /usr/local/lib/thunderbird-3.0a1pre

fwiw, this bug is about that build failure ;) ... try the patch.

Comment 4

[Alexander Sack]

ok i added depends on bug 386904 ... which tracks the application.ini issue.

Comment 5

[walter sheets]

Okay, my only nit is that $(SYSINSTALL) should be used instead of $(INSTALL).
Otherwise a symlink to platform.ini gets installed instead of the file.

Thanks!

Comment 6

[Alexander Sack]

Created attachment 270975 [details] [diff] [review]
SYSINSTALL platform.ini

good catch. This one does sysinstall.

Comment 9

[Benjamin Smedberg]

This was fixed by the checkin for bug 389673