387294 - width of left pane ('all folders' and 'agenda/todo/calendar' - new 'mode toolbar' - ) is not set properly at startup

Status: VERIFIED FIXED

(Calendar :: Lightning Only, defect)

Description

[juergen.edner]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1.4) Gecko/20070515 Firefox/2.0.0.4
Build Identifier: Thunderbird v2.0.0.4 (20070604) / Lightning v0.7pre (2007070403)

After installing the latest nightly build of lightning v0.7pre (2007070403) the new mode toolbar appears at the bottom of the left pane right under the 'all folder' view.
If I resize this left pane, independently if it shows the 'all folders' view in Thunderbird or the 'agenda/todo/calendar' in Lightning, this change doesn't persist after a restart of Thunderbird. It always starts with the default width.

Reproducible: Always

Steps to Reproduce:
1. open Thunderbird
2. resize the width of the left pane
3. restart Thunderbird

or

1. start Thunderbird
2. switch to the calendar view
3. resize the width of the left pane
4. restart Thunderbird
5. switch to the calendar view

Actual Results:  
If I resize this left pane, independently if it shows the 'all folders' view in Thunderbird or the 'agenda/todo/calendar' in Lightning, this change doesn't persist after a restart of Thunderbird. It always starts with the default width.

Expected Results:  
The width of the left pane should persist and automatically set at startup.

Comment 1

[Michael Büttner (no reviews TFN)]

I think this is my turn...

Comment 2

[Jay Rossiter]

This is an incredibly simple, yet infuriating little bug.  In the last few nightly builds the default startup size for the folder sidebar has gotten smaller and smaller.

Comment 3

[Stefan Sitter [:ssitter]]

Attachment: rev0 - persist width on box

Sorry for stealing the bug. I just tested this patch and it works fine.

Comment 4

[Jay Rossiter]

Confirmed.  Fix from #3 works.

Comment 5

[Pete Riley]

Would you make it save two different widths for the left pane:  one for mail mode and one for calendar mode?  Or does this require a new bug request?

My mailbox names (in mail mode) are much wider than my calendar names (in calendar mode).  Such an enhancement would allow me to show more detail in the month view by making the left pane narrower in calendar mode.

Comment 6

[Michael Büttner (no reviews TFN)]

Comment on attachment 271546 [details] [diff] [review]
rev0 - persist width on box

>+  <vbox id="ltnModeBox" insertbefore="folderPaneBox" persist="collapsed width">
r=mickey.

Comment 7

[Michael Büttner (no reviews TFN)]

patch checked in on trunk and MOZILLA_1_8_BRANCH

-> FIXED

Comment 8

[Michael Büttner (no reviews TFN)]

(In reply to comment #5)
> Would you make it save two different widths for the left pane:  one for mail
> mode and one for calendar mode?  Or does this require a new bug request?
Could you please file an enhancement bug for this request? Although I'm totally with you, I'd suggest to just go ahead with this patch and address the request separately. The reason is that remembering different widths involves more than adding just a 'persist' attribute (which I just forgot). Thanks for all the valuable feedback, BTW.

Comment 9

[Pete Riley]

Thanks, I created bug 387575 for two different widths of the left pane.

Comment 11

[Jean-Michel Reghem]

adding "mode toolbar" in summary for beter bugzilla search

Comment 12

[Andreas Treumann]

Verified in lightning build 2007071904, task is fixed.