387744 - show the search builder and search results in the organizer center pane when the user starts typing

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Dietrich Ayala (:dietrich)]

see the bug URL for mockups and notes. not sure if the search builder should be *in* the content pane, or maybe another toolbar-style box across the top.

Comment 1

[Alex Faaborg [:faaborg] (Firefox UX)]

I'm still working on the mockup for this, ping me if I am blocking anyone.

Comment 2

[Dietrich Ayala (:dietrich)]

Attachment: wip

Comment 3

[Alex Faaborg [:faaborg] (Firefox UX)]

Here is the most recent mockup of the advanced search UI in the Places Organizer, my apologies for the delay in getting this to you:

http://people.mozilla.com/~faaborg/files/granParadisoUI/placesSearch_i5AdvancedSearch.png

Text from the mockup:

Users enter the advanced search UI as soon as they begin typing a search query into the search bar, or by hitting the advanced search button in the bookmarks toolbar.  The search scope is automatically set to "all bookmarks", but their previous location in the Places Organizer (shown below as "folder name"), is also an option.
---
The Scope Bar allows for multiple selection, or for no items to be selected (in which case there will be no results).  "Bookmark is in folder" is also one of the possible filters.
---
Advanced searching is commonly accomplished using a 5 step task flow:

1.  Enter search text
2.  Define scope
3.  Apply specific filters
4.  View search results
5.  Save search as smart folder

Here is how this 5 step task flow is designed in the advanced search in Vista, and OS X's Spotlight
---
Vista's advanced search does not automatically update on specific filters
---
Apple refers to this control as the "Scope Bar" and it appears in the Finder, Mail.app, Address Book, and Safari
---
Each filter takes the form of subject -> predicate -> object

Comment 4

[Dietrich Ayala (:dietrich)]

Attachment: more

Comment 5

[Dietrich Ayala (:dietrich)]

Attachment: screenshot - mac

Comment 6

[Dietrich Ayala (:dietrich)]

Attachment: more

Comment 7

[Dietrich Ayala (:dietrich)]

Attachment: more

Comment 8

[Dietrich Ayala (:dietrich)]

Attachment: fix v1

- show builder when user starts typing
- adds scope bar
- various other fixes of brokenness

Comment 9

[Asaf Romano (gone)]

Comment on attachment 282619 [details] [diff] [review]
fix v1

there's some cleanup to do here but nothing that should black landing this, r=mano.

Comment 10

[Dietrich Ayala (:dietrich)]

Checking in browser/components/places/content/advancedSearch.inc;
/cvsroot/mozilla/browser/components/places/content/advancedSearch.inc,v  <--  advancedSearch.inc
new revision: 1.5; previous revision: 1.4
done
Checking in browser/components/places/content/places.js;
/cvsroot/mozilla/browser/components/places/content/places.js,v  <--  places.js
new revision: 1.109; previous revision: 1.108
done
Checking in browser/components/places/content/places.xul;
/cvsroot/mozilla/browser/components/places/content/places.xul,v  <--  places.xul
new revision: 1.88; previous revision: 1.87
done
Checking in browser/locales/en-US/chrome/browser/places/places.dtd;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/places/places.dtd,v  <--  places.dtd
new revision: 1.35; previous revision: 1.34
done
Checking in browser/themes/pinstripe/browser/places/places.css;
/cvsroot/mozilla/browser/themes/pinstripe/browser/places/places.css,v  <--  places.css
new revision: 1.15; previous revision: 1.14
done
Checking in browser/themes/winstripe/browser/places/places.css;
/cvsroot/mozilla/browser/themes/winstripe/browser/places/places.css,v  <--  places.css
new revision: 1.16; previous revision: 1.15
done

Comment 11

[Alfred Kayser]

Note, the first button in the 'scopeBar' (with id=scopeBarTitle) should not be a 'toolbarbutton'. Now it looks like people can click this button, but as it as no 'oncommand' it does nothing. This item must be a 'label' and not a 'toolbarbutton'.

The line to be fixed:
<toolbarbutton id="scopeBarTitle" label="&search.label;"/>
into
<label id="scopeBarTitle" value="&search.label;"/>

Comment 12

[Ton [:Tonnes]]

Considering last post’s date it seems unlikely, but could it be the show/hide arrow (and text) completely work in the opposite direction than they should? I haven’t looked at this in detail before, but filling in the search field using the 20080218 nightly the builder appears, accompanied by an ‘Open’ arrow and ‘Show builder’ text for closing it. Reopening the builder needs to be done with a ‘Close’ arrow and ‘Hide..’ text.

Comment 13

[Axel Hecht [:Pike]]

Filed bug 423560 on Ton's issue in comment 12.

Comment 14

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv