Closed
Bug 38792
Opened 26 years ago
Closed 26 years ago
formatting toolbar resizes during load and after first use or mouse-hover[modern skin]
Categories
(SeaMonkey :: Themes, defect, P3)
Tracking
(Not tracked)
VERIFIED
FIXED
M18
People
(Reporter: Brade, Assigned: sfraser_bugs)
References
Details
(Keywords: polish, Whiteboard: [nsbeta3+] removed nsbeta2 and dogfood nomination)
In Composer, on the formatting toolbar, the indent and outdent icons are
initially drawn with a border and they are drawn too small so that each image is
smooshed.
Expect: icons not be smooshed in formatting toolbar
Note: clicking in the main edit area causes the toolbar to be drawn properly.
Comment 1•26 years ago
|
||
This is obviously not a Composer bug, but a XUL layout problem. It looks ok
on windows. I'll find appropriate XPFE person to assign this to.
Obviously this must be fixed for beta2
Putting on [nsbeta2+][dogfood-] radar. Does not need a fix ASAP for daily work,
but we should fix this for beta2.
Whiteboard: [nsbeta2+][dogfood-]
Comment 3•26 years ago
|
||
This is happening *only* in release (i.e optimized) builds -- we don't see it
at all in debug builds. Smells like an unitialized variable to me.
Probably in box layout or widget code.
We can't be the only module with this problem, are we?
Status: NEW → ASSIGNED
| Reporter | ||
Comment 4•26 years ago
|
||
Charley's comments are *NOT* true. I see this in debug builds too. Sorry I
wasn't clearer on my initial report.
Comment 5•26 years ago
|
||
Just on Mac? I don't see it on Windows.
Comment 6•26 years ago
|
||
I looked at release builds today for Windows and Mac and don't see any problem.
Status: ASSIGNED → RESOLVED
Closed: 26 years ago
Resolution: --- → WORKSFORME
| Reporter | ||
Comment 8•26 years ago
|
||
reopening; with yesterday's build, I still see the formatting toolbar resize on
Mac.
From Task menu, choose Composer (new window appears)
I see the caret appear and then disappear.
At this point the toolbar resizes a little bit.
When I click in the content area to give it focus, the formatting toolbar shrinks
a little bit. (I don't see any changes after this point.)
Status: VERIFIED → REOPENED
Resolution: WORKSFORME → ---
Comment 9•26 years ago
|
||
But are the buttons the correct size when finished with this slow
"relayout shuffle"? The original bug was about "smooshed" icons.
I see general slowness applying the CSS styles for the buttons on Windows: at
first you see borders, then they disappear after a second or two. Clicking in
the content area or mousing over the toolbar seems to trigger the proper
final layout.
It's obviously a XUL/XBL/layout problem.
Eric or Peter: Are you seeing this relayout "shuffling" as the window is opening
in any other modules?
Status: REOPENED → ASSIGNED
Component: Editor → XP Toolkit/Widgets
| Reporter | ||
Comment 10•26 years ago
|
||
The point is that the toolbar resizes several times. Once after initial painting
and another time (minutes later?) when you actually click in it to type. Maybe
it's focus-related?
Comment 11•26 years ago
|
||
Changing summary to better describe behavior.
This is an XPFE problem -- I'll let Peter decide the best one to assign to.
Assignee: cmanske → trudelle
Status: ASSIGNED → NEW
Summary: formatting toolbar resizes; icons smooshed → formatting toolbar resizes during load and after first use or mouse-hover
Comment 12•26 years ago
|
||
box reflow? reassigning to evaughan. lowering severity to minor
Assignee: trudelle → evaughan
Severity: critical → minor
Updated•26 years ago
|
Status: NEW → ASSIGNED
Whiteboard: [nsbeta2+][dogfood-] → [nsbeta2+][dogfood-] rare and hard to reproduce
| Reporter | ||
Comment 13•26 years ago
|
||
I disagree with the comments added to the status whiteboard "rare and hard to
reproduce" so I am removing it for now; I am seeing this even more frequently.
I saw it very often yesterday when I would drag or drop in Composer (as well as
when the window first appears and as well as when the edit area gets first focus
by user). It's quite disconcerting to have the edit area resize while I'm trying
to drop text in a particular location.
Whiteboard: [nsbeta2+][dogfood-] rare and hard to reproduce → [nsbeta2+][dogfood-]
Comment 15•26 years ago
|
||
Ok this happens because of this:
1) The window comes up.
2) some javascript first and tell the dedent button on the toolbar it should
have a border.
Problem. The button grows as it should because you just put a border on it. That
will indeed make it bigger. Try adding a margin around the unseleced button that
is the same size as the border. Then when the button is selected make sure you
remove the margin so it is replaced by the border.
Assignee: evaughan → cmanske
Status: ASSIGNED → NEW
Comment 16•26 years ago
|
||
We, i.e. Composer CSS, should not have to be doing anything! The button borders
should be determined by global "skins" CSS when we use the appriate classes
for toolbar buttons. So this is really a XPFE bug. I know Ben is swamped, so
I'll try to track down where to fix it.
But this still doesn't address the painfully slow application of the CSS styles:
we see the toolbar appear in some basic style, then as the CSS triggers
reflow because of specific toolbar button classes, background images and other
styles display slowly.
Comment 18•26 years ago
|
||
M16 has been out for a while now, these bugs target milestones need to be
updated.
Updated•26 years ago
|
Status: NEW → ASSIGNED
Target Milestone: M16 → M17
Comment 19•26 years ago
|
||
There's nothing Composer-specific here. We are using the global
class="button-toolbar" for all the buttons on our "Format" toolbar.
So any problems are the responsibility of the UI/skins people.
Ben is overloaded, so handing off to Paul first to see if he can find
appropriate resources.
P.S.: What component should we use for skins issues?
Assignee: cmanske → hangas
Status: ASSIGNED → NEW
Component: XP Toolkit/Widgets → XP Apps: GUI Features
Comment 20•26 years ago
|
||
German, please take a look at this one. If the descriptions are correct then we
should be able to find a set of button styles in modern that cause this problem.
Once this is found and fixed we will probably have to put the fix into Classic as
well.
Assignee: hangas → german
Component: XP Apps: GUI Features → Themes
Comment 21•26 years ago
|
||
I'll look into it. ETA set to 7/21.
Status: NEW → ASSIGNED
Whiteboard: [nsbeta2+][dogfood-] → [nsbeta2+][dogfood-] ETA 7/21
Comment 22•26 years ago
|
||
cause of this not yet found in modern set ETA to 7/24
Whiteboard: [nsbeta2+][dogfood-] ETA 7/21 → [nsbeta2+][dogfood-] ETA 7/24
Comment 23•26 years ago
|
||
Per today' eng mgr beta2 bug triage, moving from [nsbeta2+] to [nsbeta2-]
Whiteboard: [nsbeta2+][dogfood-] ETA 7/24 → [nsbeta2-][dogfood-] ETA 7/24
Comment 24•26 years ago
|
||
This is a minor cosmetic issue IMO and should not have been nsbeta2'd or
dogfood'd in the first place, as it is midly annoying but we would never stop a
build based on it. Will fix when we update the look of modern starting after
nsbeta2.
I do not see this show up in Classic so I am adding [modern skin] to the subject
Comment 25•26 years ago
|
||
nominate as nsbeta3, polish
| Assignee | ||
Comment 26•26 years ago
|
||
I have CSS fixes for this.
Assignee: german → sfraser
Status: ASSIGNED → NEW
Comment 27•26 years ago
|
||
smfr, go ahead and check it in
Whiteboard: removed nsbeta2 and dogfood nomination → [nsbeta3+] removed nsbeta2 and dogfood nomination
Target Milestone: M17 → M18
| Assignee | ||
Comment 28•26 years ago
|
||
New images and CSS fixes this.
Status: NEW → RESOLVED
Closed: 26 years ago → 26 years ago
Resolution: --- → FIXED
Updated•18 years ago
|
Product: Core → SeaMonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•