Closed Bug 387938 Opened 17 years ago Closed 17 years ago

Modify MMgc to support ActionMonkey stage 0

Categories

(Core :: JavaScript Engine, defect)

Other Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jorendorff, Assigned: jorendorff)

References

Details

Attachments

(2 files)

* Add support for js_IsAboutToBeFinalized. 

    * Add support for callbacks (JS_SetGCCallback and JS_SetGCThingCallback, in jsapi.h). 

    * Add support for enumerating GC roots, to support js_MapGCRoots in jsgc.h. (target of opportunity)

    * Add support for named GC roots (target of opportunity)
Depends on: 388011
Attachment #272803 - Flags: review?(edilee)
Depends on: 388970
Comment on attachment 272803 [details] [diff] [review]
Add GC::IsAboutToBeFinalized()

hg/actionmonkey-tamarin
changeset 90:  	ab9b90f88f09
Attachment #272803 - Flags: review?(edilee) → review+
I don't know of anything else that needs special MMgc support.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Depends on: 389713
OK, bug 389713 does.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
No need for a separate IsAboutToBeFinalized if js_IsAboutToBeFinalized can check it with a !GC::GetMark()
Attachment #274635 - Flags: review?(jorendorff)
Comment on attachment 274635 [details] [diff] [review]
Remove GC::IsAboutToBeFinalized()

Yep.  Bug 389420 comment 20 explains why we don't need this to implement js_IsAboutToBeFinalized().
Attachment #274635 - Flags: review?(jorendorff) → review+
Comment on attachment 274635 [details] [diff] [review]
Remove GC::IsAboutToBeFinalized()

pushed to hg/actionmonkey-tamarin
remote: added 1 changesets with 1 changes to 1 files
changeset 118:  	1e5ac29bc9f7
Status: REOPENED → RESOLVED
Closed: 17 years ago17 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.