Closed
Bug 387938
Opened 17 years ago
Closed 17 years ago
Modify MMgc to support ActionMonkey stage 0
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jorendorff, Assigned: jorendorff)
References
Details
Attachments
(2 files)
|
938 bytes,
patch
|
Mardak
:
review+
|
Details | Diff | Splinter Review |
|
987 bytes,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
* Add support for js_IsAboutToBeFinalized.
* Add support for callbacks (JS_SetGCCallback and JS_SetGCThingCallback, in jsapi.h).
* Add support for enumerating GC roots, to support js_MapGCRoots in jsgc.h. (target of opportunity)
* Add support for named GC roots (target of opportunity)
|
Assignee | |
Comment 1•17 years ago
|
||
|
|
Assignee | |
Updated•17 years ago
|
Attachment #272803 -
Flags: review?(edilee)
|
||
Comment 2•17 years ago
|
||
Comment on attachment 272803 [details] [diff] [review]
Add GC::IsAboutToBeFinalized()
hg/actionmonkey-tamarin
changeset 90: ab9b90f88f09
Attachment #272803 -
Flags: review?(edilee) → review+
|
|
Assignee | |
Comment 3•17 years ago
|
||
I don't know of anything else that needs special MMgc support.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 4•17 years ago
|
||
OK, bug 389713 does.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
||
Comment 5•17 years ago
|
||
No need for a separate IsAboutToBeFinalized if js_IsAboutToBeFinalized can check it with a !GC::GetMark()
Attachment #274635 -
Flags: review?(jorendorff)
|
|
Assignee | |
Comment 6•17 years ago
|
||
Comment on attachment 274635 [details] [diff] [review]
Remove GC::IsAboutToBeFinalized()
Yep. Bug 389420 comment 20 explains why we don't need this to implement js_IsAboutToBeFinalized().
Attachment #274635 -
Flags: review?(jorendorff) → review+
|
|
||
Comment 7•17 years ago
|
||
Comment on attachment 274635 [details] [diff] [review]
Remove GC::IsAboutToBeFinalized()
pushed to hg/actionmonkey-tamarin
remote: added 1 changesets with 1 changes to 1 files
changeset 118: 1e5ac29bc9f7
|
|
Assignee | |
Updated•17 years ago
|
Status: REOPENED → RESOLVED
Closed: 17 years ago → 17 years ago
Resolution: --- → FIXED
|
||
Updated•17 years ago
|
Flags: in-testsuite-
You need to log in
before you can comment on or make changes to this bug.
Description
•