Closed
Bug 388970
Opened 18 years ago
Closed 18 years ago
ActionMonkey: MMgc: Add support for JS_SetExtraGCRoots()
Categories
(Tamarin Graveyard :: Virtual Machine, defect)
Tamarin Graveyard
Virtual Machine
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: jorendorff, Assigned: jorendorff)
References
Details
Attachments
(1 file)
|
3.44 KB,
patch
|
Mardak
:
review+
|
Details | Diff | Splinter Review |
See attached patch. This is a better hook for firing JSGC_MARK_END, too.
Attachment #273136 -
Flags: review?(edilee)
|
||
Updated•18 years ago
|
Status: NEW → ASSIGNED
|
|
||
Comment 1•18 years ago
|
||
Comment on attachment 273136 [details] [diff] [review]
add GCCallback::lastmark() callback
>+ for (GCCallback *cb = m_callbacks; cb; cb = cb->nextCB)
>+ cb->lastmark(work);
Nice. collapsing of the while :)
>+ * dynamically at collection time. The GCCallback may
>+ * call the PushWorkItem() and Mark() methods to
>+ * participate in marking.
We could clarify that GCCallback can call the "locally defined" ones and not the gc->ones because the subclasses aren't friends of GC.
Attachment #273136 -
Flags: review?(edilee) → review+
|
Assignee | |
Comment 2•18 years ago
|
||
Pushed to actionmonkey-tamarin.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
|
||
Comment 3•18 years ago
|
||
Transfer Bug from Core->Tamarin to Tamarin Product.
Component: Tamarin → Virtual Machine
Product: Core → Tamarin
Version: Other Branch → unspecified
|
|
||
Updated•16 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•