387988 - UpdateTranslucentWindow Bug

Status: RESOLVED DUPLICATE of bug 385888

(Core :: Widget: Win32, defect)

Description

[Jonathan Steele]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007071213 Firefox/3.0a7pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007071213 Firefox/3.0a7pre

1) There is a bug that is in the UpdateTranslucentWindow functions. It has needConversion = PR_FALSE; in the Cairo builds. if needConversion is false then ::DeleteDC(hMemoryDC); wouldn't executed. I have removed needConversion since it is an useless check. 

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Jonathan Steele]

Attachment: Removed Useless checks and killed a dead gfx code

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

You shouldn't be deleting hMemoryDC since it's actually stored in mMemoryDC and might be used again ... right?

Comment 3

[Jonathan Steele]

(In reply to comment #2)
> You shouldn't be deleting hMemoryDC since it's actually stored in mMemoryDC and
> might be used again ... right?
> 

right. your want to deleting mMemoryDC then?

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

As far as I can tell, the widget does not own mMemoryDC when MOZ_CAIRO_GFX is defined. It's just set to mMemoryDC = mTranslucentSurface->GetDC(), which does not transfer ownership.

Probably it would be simpler if we remove mMemoryDC altogether and just use mTranslucentSurface->GetDC() whenever we need to get it.

Comment 5

[Jonathan Steele]

Attachment: Removed mMemoryDC competely

Comment 6

[Jonathan Steele]

Is this bug is duplicate of 385888?