389242 - Kill old gfx and obsolete code in nsWindow

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Jonathan Steele]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007072304 Firefox/3.0a7pre
Build Identifier: 

Remove all the old, dead gfx and obslete code from nsWindow. I had a patch for it. I'm look around of this file, it is telling me that Scroll functions is obsolete? Could we remove that functions?

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Jonathan Steele]

Attachment: Remove dead GFX codes in nsWindow.cpp

I had removed isWin2k() since it was in older gfx code, useless functions.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

You should also remove UpdateTranslucentWindowAlphaInner, which is no longer called.

Comment 3

[Jonathan Steele]

(In reply to comment #2)
> You should also remove UpdateTranslucentWindowAlphaInner, which is no longer
> called.
> 

Thanks. that be in a different patch. 

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 273635 [details] [diff] [review]
Remove dead GFX codes in nsWindow.cpp

OK

Comment 5

[Jonathan Steele]

Attachment: Removed UpdateTranslucentWindowAlpha

Comment 6

[Jonathan Steele]

Attachment: Removed dead GFX and UpdateTranslucentWindowAlpha in nsWindow.h

Comment 7

[Jonathan Steele]

Attachment: Clean up IF and removed DummyDialogProc

1) Clean up header when it uses #ifndef WINCE and #ifdef WINCE into 1.
2)  DummyDialogProc callback  appeared it is not being used.

Comment 8

[Jonathan Steele]

Attachment: Removed SetWindowRegionToAlphaMask

SetWindowRegionToAlphaMask isn't be used when the Cairo builds is shipped.

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

The other two patches need to be combined into one patch; if they're not landed together, the build might break.

Comment 10

[Jonathan Steele]

Attachment: Combine Patches of nsWindow.cpp and h files

Comment 11

[Adam Guthrie]

Jonathan, I think you'll need to request approval1.9 for this patch per the rules laid out here (but it looks like Eli has already done this): http://groups.google.com/group/mozilla.dev.planning/browse_thread/thread/f569a23ce266a451/265344ae5291dee0#265344ae5291dee0.

Comment 12

[Jonathan Steele]

Attachment: Combine All 4 patches into 1

Comment 13

[Jonathan Steele]

Attachment: Combine all 4 patches into 1

Sorry about last combine patches, it removed a wrong line.

Comment 14

[Jonathan Steele]

Attachment: Combine All 4 patches into 1 patch, Part 3.

Comment 15

[Peter Weilbacher]

Hmm, I just checked in the same (or very similar) patch for Bug 385888. Are there parts of this one that are still needed?

Comment 16

[Jonathan Steele]

(In reply to comment #15)
> Hmm, I just checked in the same (or very similar) patch for Bug 385888. Are
> there parts of this one that are still needed?
> 

Yes.

Comment 17

[Peter Weilbacher]

Could you then please create a new one against the current trunk for checkin?

Comment 18

[Jonathan Steele]

(In reply to comment #17)
> Could you then please create a new one against the current trunk for checkin?
> 

Sure.

Comment 19

[Jonathan Steele]

Attachment: Against the Current Trunk

Comment 20

[Peter Weilbacher]

OK, checked patch into trunk.

Comment 21

[Jonathan Steele]

Looks like I found 2 Cairo checks in nsWindow.h file. It should be removed. I'm reopening this bugs to correct that. 

Comment 22

[Jonathan Steele]

Attachment: Removal left-over a dead gfx code

Comment 23

[Nickolay_Ponomarev]

don't you need r+sr+a before checking this in?

Comment 24

[Reed Loden [:reed]]

Checking in widget/src/windows/nsWindow.h;
/cvsroot/mozilla/widget/src/windows/nsWindow.h,v  <--  nsWindow.h
new revision: 3.242; previous revision: 3.241
done