388112 - Oversize context menu no longer scrolls, just extends offscreen

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Phil Ringnalda (:philor)]

After the landing of bug 279703, too-large context menus are no longer cropped, with scrolling arrows, they now just extend infinitely offscreen.

STR:
1. If you don't already have it, add the boolean pref extensions.checkCompatibility set to false, so I don't have to repackage my test extension from years ago.
2. Install https://bugzilla.mozilla.org/attachment.cgi?id=182968 which is an extension from bug 283679 that adds a bunch of context menu items when you right click an image (or, the actual user-step, keep installing extension after extension until your context menu's that bloated).
3. Restart, right click an image.

Actual:
The context menu shows, extending off the bottom of the screen with no way to get to the invisible items.

Expected:
At least, the 1.8 behavior of cropping the menu to the size from the click spot to the edge of the screen, with scrolling arrows at each end (and for bonus points, without the bug 283679 behavior of then showing them in context menus that don't need them), or possibly the behavior requested amidst all the spam in bug 245163 of first moving the origin toward the top of the screen, and then only overflowing if the whole menu still won't fit.

Comment 1

[Neil Deakin]

Attachment: possible fix

Not sure if this is the right fix, and I unfortunately don't remember what this line of code was added for. I don't see any issues myself, but it would need more eyes to do some testing here.

Comment 2

[Neil Deakin]

Attachment: include a test

Haven't seen any issues running with this. I suspect I added this line to workaround an issue I ended up fixing a different way.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 275620 [details] [diff] [review]
include a test

OK, let's give it a shot

Comment 4

[Neil Deakin]

Had to disable one of the tests here, but will investigate it

Comment 5

[Neil Deakin]

Attachment: fix the todo line in the test by making sure to add the window offset to the rectangle offsets in every situation

Comment 6

[Asaf Romano (gone)]

Comment on attachment 276037 [details] [diff] [review]
fix the todo line in the test by making sure to add the window offset to the rectangle offsets in every situation

r=mano

Comment 7

[Neil Deakin]

Checked in the updated test