283679 - Opening scrollable context menu adds scroll arrows to ALL context menus

Status: RESOLVED WORKSFORME

(Core :: XUL, defect)

Description

[John Collins]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050222 Firefox/1.0+ (MOOX M2)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050222 Firefox/1.0+ (MOOX M2)

any page with frames or a live bookmark link should work...

Upon right clicking anything that has an extra large context menu, scroll arrows
are added to the context menu.  They remain on a global scale until firefox is
restarted.

Reproducible: Always

Steps to Reproduce:
1.installing the clustybar extension may help--extends the context menu
2.right click on a frame/image or anything that opens scrollable context menu
(try www.frames.com)
3.

Actual Results:  
all context menus now have scroll arrows regardless of whether they are scrollable

Expected Results:  
context menus should not be affected on a global scale

using 02/22 Moox M2 (SSE) build, with noia theme; 
using, among others, clustybar and deskcut extensions

another test example:
http://www.extensionsmirror.nl/peter6/rss_link.html
(right click on the livebookmark)

Comment 1

[John Collins]

*** Bug 283674 has been marked as a duplicate of this bug. ***

Comment 2

[Phil Ringnalda (:philor)]

Confirmed in Firefox and the suite, on Windows at least. Regression window is
2005012707 to 2005012816, where the only thing obviously touching menus is bug
279308 - bz, could you have a look when you get a chance? I'll attach an
extension for easy testing in a second.

Comment 3

[Phil Ringnalda (:philor)]

Attachment: Context menu bloater, v.2

Revised version of my Bloaty extension from bug 245163, only adds useless items
when right-clicking an image. Install, and right-click off an image, should
have no scrolling arrows, right-click an image, should have needed scrolling
arrows, right-click off an image, should have useless scrolling arrows.

Comment 4

[Phil Ringnalda (:philor)]

*** Bug 293290 has been marked as a duplicate of this bug. ***

Comment 5

[Boris Zbarsky [:bzbarsky]]

I'm not likely to have time to debug this any time soon... (read: not before 1.1
ships).  Menu opening is just pretty broken in general (see bug 279703) but
changing any aspects of it at this late stage in the game is just likely to lead
to more regressions.  Once bug 279703 is fixed, we should revisit this bug.

Comment 6

[Adam Guthrie]

*** Bug 310475 has been marked as a duplicate of this bug. ***

Comment 7

[Simon Bünzli]

FYI: It seems that the official way of getting the scroll arrows away is to get
the context menu note that it's got enough space - through an underflow event.
However these are much rarer than probably expected. Anyway, the arrows will
disappear again if you manage to trigger such an event by opening the context
menu just close enough to a screen border that the whole menu (including the
arrows) fits on screen.

Comment 8

[Simon Bünzli]

Sorry for the bugspam! The behavior noted just above seems to happen only (or
mostly) in the Extensions manager where one menu item is hidden after the
context menu is displayed, which leads to a layout reflow and in the border case
to the scarce underflow event. Without that reflow, you're probably out of luck.

Comment 9

[Ria Klaassen (not reading all bugmail)]

*** Bug 320619 has been marked as a duplicate of this bug. ***

Comment 10

[Adam Guthrie]

*** Bug 320878 has been marked as a duplicate of this bug. ***

Comment 11

[Mike Connor [:mconnor]]

Depends on arch work that's almost certainly trunk only.  Bumping to gecko nom list.

Comment 12

[Phil Ringnalda (:philor)]

*** Bug 340401 has been marked as a duplicate of this bug. ***

Comment 13

[Darin Fisher]

Not going to block 1.8.1 for this bug.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Phil, if I install bloaty now on a current trunk build now that Enn's popup rewrite has landed, I get no scroll arrows when right-clicking an image, just an insanely long tooltip. However, the tooltip does restore back to the right size if I right-click off the image again. So that said, how does that behavior affect this bug?

Comment 16

[Phil Ringnalda (:philor)]

Blurgl. That affects this bug by making it now blocked by bug 388112, since there's no way of knowing whether or not they get added to all menus after they are once shown, if they aren't even shown when they are needed.

Comment 17

[RenegadeX]

If it hadn't been taken care of previously, thanks to the (long-awaited) FIX of  Bug 342619 - "Don't use scroll arrows for context menus when repositioning would allow showing all menu items", as of FF3.2a1 or thereabouts, this bug is now RESOLVED. Yay!

However, I can't change the Bug status..