388167 - Hiding the first toolbar leads to a surplus line (Classic: 1px, Luna: 2px)

Status: RESOLVED WONTFIX

(Core :: Widget: Win32, defect)

Description

[Simon Bünzli]

No regression from bug 243078 or one of its dependencies, though - this never looked correctly for Toolkit 1.8 applications, either (Classic: 1px, Luna: 1px).

The correct fix would probably be to not treat the first toolbar in a toolbox differently at all and just have the toolbox eat surplus lines at the top through a negative margin.

Comment 1

[Simon Bünzli]

Attachment: screenshot (Classic/Luna, first toolbar shown/hidden)

Comment 2

[Simon Bünzli]

Attachment: use CSS hackery to hide the top 2px from the first toolbar

The easiest way around this issue is indeed to simply use a negative margin on the toolbox which hides the surplus separator line from the natively styled toolbar resp. a bogus border from the CSS styled toolbox (where the separator above the first toolbar is actually wanted).

This has the consequence of an unfortunate dependency on toolbar.css, but this may be unavoidable as I see no other way of hiding the top of an element than by a negative margin which can't be set from an nsITheme implementor.

The alternative to this treat-all-toolbars-the-same approach would involve figuring out whether a toolbar is indeed the first visible one, which isn't my piece of cake, though (see bug 337771 comment #14).

Whatever happens for native themeing, the easier approach will anyway work for CSS styled toolbars (alternatively using 1px top/bottom borders for the toolbars and letting the toolbox just add a 1px ThreeDShadow border above them all).

Comment 3

[Simon Bünzli]

Comment on attachment 272545 [details] [diff] [review]
use CSS hackery to hide the top 2px from the first toolbar

>Index: toolkit/themes/winstripe/global/toolbar.css
>+  -moz-border-top-colors: ThreeDShadow ThreeDHighlight !important;
That !important is of course not meant to be there.

Comment 4

[Boris Zbarsky [:bzbarsky]]

I'm really the wrong person to sr this.  Someone who's more familiar with UI stuff (Neil Rashbrook?) would be better.

Comment 5

[[e-mail]]

Comment on attachment 272545 [details] [diff] [review]
use CSS hackery to hide the top 2px from the first toolbar

I don't do toolkit themes, but I don't see how this hides the top of the first toolbar.

Comment 7

[Dão Gottwald [:dao]]

Windows XP isn't supported anymore.