526461 - When I hid menubar in a classic theme, there is an unnecessary highlight between title bar and navigation bar,

Status: RESOLVED DUPLICATE of bug 388167

(Core :: Widget: Win32, defect)

Description

[Alice0775 White]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2b2pre) Gecko/20091103 Firefox/3.5.1 (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2b2pre) Gecko/20091103 Firefox/3.5.1 (.NET CLR 3.5.30729)

When I hid menubar in a classic theme, there is an unnecessary highlight between title bar and navigation bar,

Reproducible: Always

Steps to Reproduce:
1.Set Windows Visual Style to "Windows Classic"
2.Start Namoroka with new profile
3.Hit alt key to hide menubar

Comment 1

[Alice0775 White]

Attachment: picture

Comment 2

[Dão Gottwald [:dao]]

There's an XXX comment for this in nsNativeThemeWin.cpp:

702     case NS_THEME_TOOLBAR: {
703       // Use -1 to indicate we don't wish to have the theme background drawn
704       // for this item. We will pass any nessessary information via aState,
705       // and will render the item using separate code.
706       aPart = -1;
707       aState = 0;
708       if (aFrame) {
709         nsIContent* content = aFrame->GetContent();
710         nsIContent* parent = content->GetParent();
711         // XXXzeniko hiding the first toolbar will result in an unwanted margin
712         if (parent && parent->GetChildAt(0) == content) {
713           aState = 1;
714         }
715       }
716       return NS_OK;
717     }