Closed Bug 388189 Opened 13 years ago Closed 13 years ago

console spewage: "(all right -- a generic module!)"

Categories

(Core :: XPCOM, defect, trivial)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED

People

(Reporter: Dolske, Assigned: Dolske)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

When components get registered, the console has a lot of spewage:

*** Registering nsBrowserCompsModule components (all right -- a generic module!)
*** Registering BrowserDirProvider components (all right -- a generic module!)
*** Registering nsChardetModule components (all right -- a generic module!)
*** Registering nsChromeModule components (all right -- a generic module!)
*** Registering CommandLineModule components (all right -- a generic module!)
*** Registering nsComposerModule components (all right -- a generic module!)
*** Registering nsCookieModule components (all right -- a generic module!)
etc.

I'd kind of like to just remove the spewage entirely, but I seem to recall someone saying they found it useful. But the "(all right -- a generic module!)" string isn't useful. That leaves just "components" at end, so I nuked it to   make visually scanning the list easier. I think anyone working in this area will know what "Registering foo" means.

So, we end up with:
*** Registering nsBrowserCompsModule
*** Registering BrowserDirProvider
*** Registering nsChardetModule
*** Registering nsChromeModule
*** Registering CommandLineModule
*** Registering nsComposerModule
*** Registering nsCookieModule
etc
Attachment #272365 - Flags: superreview?(benjamin)
Attachment #272365 - Flags: review?(dougt)
Comment on attachment 272365 [details] [diff] [review]
Patch for review, v.1 (all right -- a trivial patch!)

i think you should leave "components" in that output so that it will look like:

*** Registering WhatEver Component

Other than that, i don't really are that much.
Attachment #272365 - Flags: review?(dougt)
Comment on attachment 272365 [details] [diff] [review]
Patch for review, v.1 (all right -- a trivial patch!)

Really I'd prefer to make this forced NSPR logging, but this is better than we have right now.
Attachment #272365 - Flags: superreview?(benjamin) → superreview+
Attached patch Patch for review, v.2 (obsolete) — Splinter Review
Address review comments.

I put "components" back in, but tweaked the order so the module name isn't buried in the middle of the line.

Eg:

*** Registering components from nsBrowserCompsModule
*** Registering components from BrowserDirProvider
*** Registering components from nsChardetModule
*** Registering components from nsChromeModule
*** Registering components from CommandLineModule
Attachment #272365 - Attachment is obsolete: true
Attachment #272514 - Flags: review?(dougt)
Comment on attachment 272514 [details] [diff] [review]
Patch for review, v.2

nits:

printf_stderr("*** Registering components in: %s\n", mModuleName);

printf_stderr("*** Unregistering components in: %s\n", mModuleName);
Attachment #272514 - Flags: review?(dougt) → review+
Checking in xpcom/glue/nsGenericFactory.cpp;
/cvsroot/mozilla/xpcom/glue/nsGenericFactory.cpp,v  <--  nsGenericFactory.cpp
new revision: 1.66; previous revision: 1.65
done
Attachment #272514 - Attachment is obsolete: true
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.