388207 - Remove the bogus and never-(properly-)shown "it's our fault :-(" feed preview error

Status: RESOLVED FIXED

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Description

[Phil Ringnalda (:philor)]

Back when I first noticed that although bug 346312 removed the way that the error.message entity ("There was an error processing this feed. It's our fault. :-( You can still subscribe to the feed if you know what it is. For reference, the error was:") was shown, it didn't remove the entity or its inclusion in the page, I thought that was only a problem in that as http://mxr.mozilla.org/l10n-mozilla1.8/search?string=error.message shows we made a whole lot of localizers translate a string with a frownie even though it wouldn't ever be seen. But, as he is wont to do, timeless noticed that you can actually see it quite easily, in feeds where there was absolutely no error.

STR:
1. Load http://www.mozilla.org/news.html
2. In the View menu, select Page Style -> No Style
3. Click the feed icon in the address bar

Comment 1

[Phil Ringnalda (:philor)]

Attachment: Remove it, v1

Comment 2

[Asaf Romano (gone)]

Comment on attachment 272383 [details] [diff] [review]
Remove it, v1

r=mano once you figure out your line endings and better-editor stories, thanks.

[You've a bug on about:mozilla, right?]

Comment 3

[Phil Ringnalda (:philor)]

browser/components/feeds/content/subscribe.xhtml 1.16
browser/locales/en-US/chrome/browser/feeds/subscribe.dtd 1.5
browser/components/feeds/src/FeedWriter.js 1.42
browser/themes/winstripe/browser/feeds/subscribe.css 1.17
browser/themes/pinstripe/browser/feeds/subscribe.css 1.18

Added "set IgnoreMano'sStrayDOSNewlines" to ~/.nanorc

about:mozilla? not me - I've got one I'll never get rid of on about:license, but not about:mozilla.