38825 - ListControlFrame::AddOption called before option added to DOM

Status: VERIFIED INVALID

(Core :: Layout, defect, P3)

Description

[rods (gone)]

AddOption gets called on the ListControlframe before it is actually added in the 
DOM. The notification is sort of a side affect of the SetParent call in the 
OptionElement.  We have talked about fixing this in the past, well here is a bug 
so we don't forget.

Comment 1

[rods (gone)]

marking M17

Comment 2

[Eric Pollmann]

Rod, does this cause nasty side-effects?  Marking Future in hopes that it
doesn't.

Comment 3

[rods (gone)]

I thought this was fixed recently, except for a minor change I needed to make 
which is why I reopened Bug #44266. So I think this bug can be marked fixed.

Comment 4

[gerardok]

massive update for QA contact.

Comment 5

[Hixie (not reading bugmail)]

Reassigning QA Contact for all open and unverified bugs previously under Lorca's
care to Gerardo as per phone conversation this morning.

Comment 6

[Eric Pollmann]

Clarifying summary

Comment 7

[bsharma]

qa contact updated.

Comment 8

[Heikki Toivonen (remove -bugzilla when emailing directly)]

SPAM. HTML Element component deprecated, changing component to Layout. See bug
88132 for details.

Comment 9

[John Keiser (jkeiser)]

This still happens in the bug 34297 rewrite (and there are specific reasons for
it), but there are zero side-effects I can think of.  Essentially, AddOption()
is now called *after* the option is added to the options[] list but *before* it
is added as an HTML child of the <select> element.

AddOption() has become more a notification than a request for action to add an
option.  From my reading of the code, this shouldn't have any adverse effects. 
In fact, I'm considering removing it entirely, along with all the annoying timer
stuff.  I could just make this the bug where I do that.  (We'll discuss first; I
can't be 100% certain there are no repercussions yet, that's why I haven't done
it already.)

Does anyone have a problem with me taking this bug?  pollmann, are you still
working on it?

Comment 10

[Kevin McCluskey (gone)]

Bulk reassigning form bugs to Alex

Comment 11

[Alexandru Savulov]

John:
if you want to take care of this bug just go ahead and reassign it to you.
I add me on the cc list please.

Comment 12

[John Keiser (jkeiser)]

Taking.

Comment 13

[John Keiser (jkeiser)]

Marking invalid.  ListControlFrame::AddOption is all but irrelevant now, and is
nothing but a notification.  Its counterpart is now
nsHTMLSelectElement::WillAddOptions(), which is much more clearly named and
doesn't run on a timer to boot.

Comment 14

[Moied]

verified Invalid