Closed
Bug 388309
Opened 18 years ago
Closed 17 years ago
"Manage Search Engines" accesskey breaks quick menu navigation to engines beginning with "M"
Categories
(Firefox :: Search, defect)
Firefox
Search
Tracking
()
VERIFIED
FIXED
Firefox 3 beta3
People
(Reporter: msv, Assigned: wladow)
Details
Attachments
(1 file)
1.44 KB,
patch
|
beltzner
:
review+
beltzner
:
approval1.9+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.4) Gecko/20061201 Firefox/2.0.0.4 (Ubuntu-feisty)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.4) Gecko/20061201 Firefox/2.0.0.4 (Ubuntu-feisty)
When opening the search bar menu (using Alt-Down) you can choose search engine by pressing the initial letter of it's name. This does not work when trying to choose a search engine with the same initial as the shortcut for Manage Search Engines (which in the English version is M)
Reproducible: Always
Steps to Reproduce:
1.Make sure you have are using an English version of Firefox and have a search engine with initial M installed (such as Mathworld or Mycroft)
2.Open search bar menu (by either clicking the icon or pressing Alt-Down when the bar is active)
3.Press M
Actual Results:
Search Engine manager is opened
Expected Results:
The first search engine with M as initial should be choosed.
If several engines have a common initial you can walk through them by repeatedly pressing the letter. With this mechanism you should be able to eventually choose "Manage Search Engines".
The letter M is specific to the English version of Firefox. A solution should of course work for other languages as well.
I have verified the existence of the problem in Linux and Windows 2000. I has existed in all Firefox 2 versions.
Reporter | ||
Updated•18 years ago
|
Version: unspecified → 2.0 Branch
Comment 1•18 years ago
|
||
We might want to remove the access key from that dropdown, for the same reason we removed the accesskeys for the bookmark menu items in bug 261985.
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Linux → All
Summary: Manage Search Engines override shortcut to search engine → "Manage Search Engines" accesskey breaks quick menu navigation to engines beginning with "M"
Version: 2.0 Branch → unspecified
Assignee | ||
Comment 2•17 years ago
|
||
Is there any decision how to fix this? Should we remove that accesskey?
Assignee | ||
Comment 3•17 years ago
|
||
remove accesskey per Comment #1
Comment 4•17 years ago
|
||
Comment on attachment 299282 [details] [diff] [review]
remove accesskey
r+a=beltzner
Attachment #299282 -
Flags: review?(gavin.sharp)
Attachment #299282 -
Flags: review+
Attachment #299282 -
Flags: approval1.9+
Assignee | ||
Updated•17 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•17 years ago
|
Target Milestone: --- → Firefox 3 M11
Comment 5•17 years ago
|
||
Checking in browser/locales/en-US/chrome/browser/searchbar.dtd;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/searchbar.dtd,v <-- searchbar.dtd
new revision: 1.4; previous revision: 1.3
done
Checking in browser/components/search/content/search.xml;
/cvsroot/mozilla/browser/components/search/content/search.xml,v <-- search.xml
new revision: 1.116; previous revision: 1.115
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Version: unspecified → Trunk
Comment 6•17 years ago
|
||
I'd appreciate it if you would make your patches from mozilla/ instead of from browser/. It saves me a bunch of time if it is done that way. Thanks!
Assignee | ||
Comment 7•17 years ago
|
||
Sure, I didn't realize that. Sorry.
Assignee | ||
Comment 8•17 years ago
|
||
Verified with Mozilla/5.0 (Windows; U; Windows NT 6.0; sk; rv:1.9b3pre) Gecko/2008012704 Minefield/3.0b3pre
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•