388317 - autocomplete and menulist popups should not be styled as native menus

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[Simon Bünzli]

Comment 1

[Simon Bünzli]

Attachment: no native appearance for autocomplete popups

If autocomplete popups got a native appearance, it wouldn't be menupopup to start with - but as it stands we can continue to style them completely through CSS.

Neil: Should all <panel>s really get a menupopup appearance (either native or through CSS) per default, anyway?

Comment 2

[Simon Bünzli]

So, there's another identical regression for menulist popups.

Comment 3

[Simon Bünzli]

Attachment: no native appearance for menulist popups

Comment 4

[Ryan Flint [:rflint] (ping via IRC for reviews)]

mozilla/toolkit/themes/winstripe/global/popup.css        1.12 	mozilla/toolkit/themes/winstripe/global/autocomplete.css 1.16 

Comment 5

[logan]

I don't know what this looks like on Windows, but it doesn't look very good on Linux. White, no borders, blends in with background of most pages... Needs a - border: 1px solid black; or some such.

Comment 6

[Sylvain Pasche]

Please see the testcase and screenshots in bug 388317, and in particular bug 388317 comment 4.

Comment 7

[Sylvain Pasche]

Damn, I was meaning bug 390711

Comment 8

[Sylvain Pasche]

I tried backing out this patch on a Windows trunk build (2007121405) and I don't see the gap between the selection and the border in the autocomplete panel (which can be seen on the screenshot posted on mozillazine).

Does somebody know what could have made this bug obsolete?

I'm asking because backing out this patch would solve bug 398242 (and remove the hack from bug 390711).

Comment 9

[Sylvain Pasche]

(In reply to comment #8)
> I'm asking because backing out this patch would solve bug 398242 (and remove
> the hack from bug 390711).

Well, that would not solve bug 398242 directly. If the policy of not using "moz-appearance: none" on panels for Windows reveals to be correct, the moz-appearance on the download info panel could be dropped for both Windows and Linux.

Comment 10

[Sylvain Pasche]

Ok, things are getting clearer. The changes on popup.css are still required, I could see the gap when removing the "-moz-appearance: none"

For the autocomple.css change, bug 355789 removed the "-moz-appearance: menupopup" on the panel element. This means setting the -moz-appearance to none explicitly in the autocomplete panel is not needed for preventing the gap between selection and border.

Neil, should I reopen this bug, remove the "-moz-appearance: none" and the #ifdef hack introduced in bug 390711?