Closed Bug 390711 Opened 12 years ago Closed 12 years ago

autocomplete dropdown has no border after 388317

Categories

(Toolkit :: Themes, defect, P3)

x86
Linux
defect

Tracking

()

VERIFIED FIXED
mozilla1.9beta2

People

(Reporter: logan+mozilla-bmo, Assigned: sylvain.pasche)

References

Details

(Keywords: platform-parity, regression)

Attachments

(4 files)

On gtk builds, the autocomplete dropdown is just plain white (no border). This blends into the background of most pages and generally looks bad. As stated in comment 5 of 388317, a "border: 1px solid black;" would take care of this.
Blocks: 388317
Attached file testcase
Attached image Linux screenshot
Attached image Windows XP screenshot
The modification made in bug 388317 for the menulist does not apply on Linux, as the Linux theme has its own popup.css file. But for autocomplete.css, it is shared between between the two.

I see two options for fixing the Linux case:
1) Keep the old -moz-appearance for linux in gnomestripe
2) Fix the CSS on Linux to have the popup looks native (not sure why background-color: -moz-field and ThreeDDarkShadow do not look native).
Duplicate of this bug: 390880
Duplicate of this bug: 391097
Flags: blocking1.9?
Keywords: regression
Duplicate of this bug: 392668
Is these two bugs are related 
https://bugzilla.mozilla.org/show_bug.cgi?id=392655

Anyone has filed a bug with gtk team ?
(In reply to comment #8)
> Is these two bugs are related

No.
Duplicate of this bug: 395990
Duplicate of this bug: 398242
Duplicate of this bug: 398497
Keywords: pp
+'ing.  Setting priority to P3.
Flags: blocking1.9? → blocking1.9+
Priority: -- → P3
Attached patch patch, v1Splinter Review
Well, ifdefs are bad, but this makes both panel and panel[type="autocomplete"] have a -moz-appearance set to menupopup on GTK (so they will have borders).
After bug 388317, panel and panel[type="autocomplete"] had their -moz-appearance set to menupopup and none respectively (see comment 4).
Attachment #288230 - Flags: review?
Attachment #288230 - Flags: review? → review?(mano)
Attachment #288230 - Flags: review?(neil)
Comment on attachment 288230 [details] [diff] [review]
patch, v1

I hope Mano means the other Neil.
Attachment #288230 - Flags: review?(neil) → review?(enndeakin)
Attachment #288230 - Flags: review?(enndeakin) → review+
Keywords: checkin-needed
Assignee: nobody → sylvain.pasche
Checking in toolkit/themes/winstripe/global/autocomplete.css;
/cvsroot/mozilla/toolkit/themes/winstripe/global/autocomplete.css,v  <--  autocomplete.css
new revision: 1.20; previous revision: 1.19
done
Checking in toolkit/themes/winstripe/global/jar.mn;
/cvsroot/mozilla/toolkit/themes/winstripe/global/jar.mn,v  <--  jar.mn
new revision: 1.38; previous revision: 1.37
done
Status: NEW → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M10
Pretty sure this bug's patch caused a regression.  

There's now a weird gray bar at the top of the dropdown, which pushes the last (or only) completion in the box out of view. See bug 403659 and the screenshots posted there.
No longer blocks: 403659
(In reply to comment #18)
> Pretty sure this bug's patch caused a regression.  
> 
> There's now a weird gray bar at the top of the dropdown, which pushes the last
> (or only) completion in the box out of view. See bug 403659 and the screenshots
> posted there.

-> regression of bug 118312
Duplicate of this bug: 401489
Duplicate of this bug: 405148
verified fixed using Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9b2) Gecko/2007121016 Firefox/3.0b2Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9b2) Gecko/2007121016 Firefox/3.0b2 on Fedora F8 by using the testcase from this bug and also testing the automcomplete dropdown.

-> Verified fixed
Status: RESOLVED → VERIFIED
Product: Core → SeaMonkey
Product: SeaMonkey → Toolkit
QA Contact: themes → themes
You need to log in before you can comment on or make changes to this bug.