disable-libxul broken in thebes

RESOLVED FIXED

Status

Firefox Build System
General
RESOLVED FIXED
11 years ago
2 months ago

People

(Reporter: Sylvain Pasche, Assigned: Benjamin Smedberg)

Tracking

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

11 years ago
Created attachment 272732 [details] [diff] [review]
v1

I was getting unresolved freetype symbols while linking in gfx/thebes/src. Before bug 373535, TK_LIBS was set to "$(MOZ_GTK2_LIBS) $(MOZ_CAIRO_LIBS)" (at least on my system), where $(MOZ_CAIRO_LIBS) included -lfreetype.

Now TK_LIBS does not include $(MOZ_CAIRO_LIBS) anymore, so freetype has to be set somewhere.

Comment 1

11 years ago
Strange, indeed I tried the patch from bug 373535 long before libxul was enabled by default, and didn't see any problem. I built successfully with disable-libxul after that patch was checked-in. I build, however with disable-freetype2 and enable-Xft as recommended for GTK2.
(Assignee)

Updated

11 years ago
Attachment #272732 - Flags: review+
(Assignee)

Comment 2

11 years ago
Comment on attachment 272732 [details] [diff] [review]
v1

This isn't right, new patch forthcoming
Attachment #272732 - Flags: review+ → review-
(Assignee)

Comment 3

11 years ago
Created attachment 272795 [details] [diff] [review]
Patch suggested by vlad, rev. 1

This solution was suggested by vlad and I'm going to commit it like this.
Assignee: nobody → benjamin
Status: NEW → ASSIGNED
(Assignee)

Updated

11 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED

Updated

11 years ago
Depends on: 392950

Updated

2 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.