373535 - firefox-on-top-of-xulrunner browser does't find libmozcairo on linux

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Walter Meinl]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9a3pre) Gecko/20070310 Minefield/3.0a3pre
Build Identifier: 

unlike windows in linux builds the browser component is finally linked against libmozcairo.
http://lxr.mozilla.org/seamonkey/source/browser/components/build/Makefile.in#88

Since the checkin for bug 78081 the build finally breaks in the broswser component as libmozcairo isn't found in the browser subtree as it resides in the xulrunner subtree.
A solution for a comparable problem was found in Bug 333874.
Patch is coming up

Reproducible: Always

Steps to Reproduce:
1.
2.
3.


Expected Results:  
browser in a ff on xr build on linux should find libmozcairo to link against it

Comment 1

[Walter Meinl]

Attachment: exchange $(DEPTH) with $(LIBXUL_DIST)/../ in configure.in for the libmozairo location

I tested this patch also with a "conventional" ff and tb build, they build as well

Comment 2

[Walter Meinl]

Comment on attachment 258199 [details] [diff] [review]
exchange $(DEPTH) with $(LIBXUL_DIST)/../ in configure.in for the libmozairo location

benjamin, if you think its the correct patch, could you please check it in? thanks

Comment 3

[Benjamin Smedberg]

Comment on attachment 258199 [details] [diff] [review]
exchange $(DEPTH) with $(LIBXUL_DIST)/../ in configure.in for the libmozairo location

1) I don't see the code you mention at http://lxr.mozilla.org/mozilla/source/browser/components/build/Makefile.in

2) non-xulrunner code should not be linking against cairo under any circumstances.

Comment 4

[Walter Meinl]

(In reply to comment #3)
> (From update of attachment 258199 [details] [diff] [review])
> 1) I don't see the code you mention at
> http://lxr.mozilla.org/mozilla/source/browser/components/build/Makefile.in
> 
> 2) non-xulrunner code should not be linking against cairo under any
> circumstances.
> 
(In reply to comment #3)
> (From update of attachment 258199 [details] [diff] [review])
> 1) I don't see the code you mention at
> http://lxr.mozilla.org/mozilla/source/browser/components/build/Makefile.in

Sorry, its not line #88, but line #90
> 
> 2) non-xulrunner code should not be linking against cairo under any
> circumstances.
> 
Last lines in browser/components/build/Makefile.in
# Mac: Need to link with CoreFoundation for Mac Migrators (PList reading code)
# GTK2: Need to link with glib for GNOME shell service
ifneq (,$(filter mac cocoa gtk2,$(MOZ_WIDGET_TOOLKIT)))
EXTRA_DSO_LDOPTS += \
  $(TK_LIBS) \
  $(NULL)
endif

include $(topsrcdir)/config/rules.mk

$(TK_LIBS) in cairo-gtk2 builds is defined in configure.in
http://lxr.mozilla.org/seamonkey/source/configure.in#4663
as TK_LIBS='$(MOZ_GTK2_LIBS) $(MOZ_CAIRO_LIBS)'
(for other cairo-platform builds its $(MOZ_CAIRO_LIBS) alone, but these are not concerned here)

Therefore, we pull MOZ_CAIRO_LIBS in cairo-gtk2 builds (but not in windows)
If that's wrong at that point we should probably separate gtk2 from mac
in this particular situation

Comment 5

[Benjamin Smedberg]

I don't know why TK_LIBS contains cairo. My impression was that TK_LIBS was for OS libraries needed by the graphics system. vlad, do you remember why you added cairo to TK_LIBS?

In any case, I'm pretty sure we shouldn't be using TK_LIBS in browser/components/builds. Instead, use MOZ_GTK2_LIBS. And for cocoa, we should link against the specific libs we need, which is probably -framework CoreFoundation

Comment 6

[Benjamin Smedberg]

oop, pav != vlad

Comment 7

[Walter Meinl]

Both, ff on top of xr and conventional ff build successfully when I remove MOZ_CAIRO_LIBS and MOZ_CAIRO_CFLAGS from TK_LIBS and TK_CFLAGS in configure.in at the lines mentioned. However, I'm using gtk+-2.10.11 that potentially could pull external cairo for linking, so I'm not sure what would happen if gtk+ is pre 2.8. 
On the other hand we could leave browser/build/Makefile.in alone in this case.

Comment 8

[Walter Meinl]

Attachment: list of $(TK_LIBS) related to cairo-gtk2

attached an lxr derived list of links against $(TK_LIBS) excluding those designated only to cocoa, mac or darwin.
In cairo-gtk2 builds we are linking in these against MOZ_GTK2_LIBS and MOZ_CAIRO_LIBS. If I understood benjamin correctly, we would need linking against MOZ_CAIRO_LIBS probably only in the gfx/thebes or gfx/src/thebes files.

Comment 9

[Walter Meinl]

Attachment: remove MOZ_CAIRO_LIBS /CFLAGS from TK_LIBS/CFLAGS

Comment 10

[Walter Meinl]

Comment on attachment 272388 [details] [diff] [review]
remove MOZ_CAIRO_LIBS /CFLAGS from TK_LIBS/CFLAGS

mostly TK_LIBS is used for mac cocoa and ifdefed. In https://bugzilla.mozilla.org/attachment.cgi?id=260475
I made a list, where either gtk2 or all other toolkits are included. I don't see where we would need MOZ_CAIRO_LIBS included in TK_LIBS.

Comment 11

[Walter Meinl]

ok, this one I've overseen in https://bugzilla.mozilla.org/attachment.cgi?id=260475
http://mxr.mozilla.org/seamonkey/source/minimo/base/Makefile.in#161

Comment 12

[Nickolay_Ponomarev]

Comment on attachment 258199 [details] [diff] [review]
exchange $(DEPTH) with $(LIBXUL_DIST)/../ in configure.in for the libmozairo location

this one is obsolete, afaics

Comment 13

[Nickolay_Ponomarev]

Checking in configure.in;
/cvsroot/mozilla/configure.in,v  <--  configure.in
new revision: 1.1851; previous revision: 1.1850
done

Comment 14

[Prasad Sunkari [:prasad]]

This patch does not let thunderbird build on linux... Is there something that I should be taking care of?

Here is my mozconfig:
  ac_add_options --disable-airbag --disable-tests --disable-optimize --enable-debug
  mk_add_options MOZ_OBJDIR=/home/tux/mozilla/build-dir
  mk_add_options MOZ_BUILD_PROJECTS="mail"
  mk_add_options MOZ_CO_PROJECT="mail calendar"
  ac_add_app_options mail --enable-application=mail
  ac_add_app_options mail --enable-extensions=default,lightning

Comment 15

[Prasad Sunkari [:prasad]]

When mking libthebes.so, the command-line is missing '-lfreetype' and causes the following errors (incomplete list) to occur.

gfxPangoFonts.o: In function `gfxPangoFont::GetMetrics()':
/home/tux/mozilla/mozilla/gfx/thebes/src/gfxPangoFonts.cpp:565: undefined reference to `FT_MulFix'
/home/tux/mozilla/mozilla/gfx/thebes/src/gfxPangoFonts.cpp:572: undefined reference to `FT_MulFix'
/home/tux/mozilla/mozilla/gfx/thebes/src/gfxPangoFonts.cpp:579: undefined reference to `FT_Get_Sfnt_Table'
/home/tux/mozilla/mozilla/gfx/thebes/src/gfxPangoFonts.cpp:582: undefined reference to `FT_MulFix'
/home/tux/mozilla/mozilla/gfx/thebes/src/gfxPangoFonts.cpp:591: undefined reference to `FT_MulFix'

Comment 16

[Mats Palmgren (:mats)]

This broke my Firefox build too (on Ubuntu-feisty).
Comparing my build log with the Tinderbox build logs it looks like my
MOZ_XFT_LIBS doesn't include -lfreetype.   Running "pkg-config --libs xft"
on my system gives the output: -lXft -lfontconfig
Tinderbox has:
-L/usr/X11R6/lib -lXft -lX11 -lfreetype -lXrender -lfontconfig

(FWIW, I hacked my /usr/lib/pkgconfig/xft.pc to fix it)

Comment 17

[Walter Meinl]

(In reply to comment #16)
> This broke my Firefox build too (on Ubuntu-feisty).
> Comparing my build log with the Tinderbox build logs it looks like my
> MOZ_XFT_LIBS doesn't include -lfreetype.   Running "pkg-config --libs xft"
> on my system gives the output: -lXft -lfontconfig
> Tinderbox has:
> -L/usr/X11R6/lib -lXft -lX11 -lfreetype -lXrender -lfontconfig
> 
> (FWIW, I hacked my /usr/lib/pkgconfig/xft.pc to fix it)
> 
Mats, Prasad, Benjamin checked in a fix, see bug 388542, does this help?

Comment 18

[Mats Palmgren (:mats)]

Yep, that fixed it, thanks.

Comment 19

[Prasad Sunkari [:prasad]]

Positive or Thunderbird too, thanks.