389293 - Few bugs, found in Ukrainian locale with Locale Inspector

Status: RESOLVED FIXED

(Mozilla Localizations :: uk / Ukrainian, defect)

Description

[Alexander L. Slovesnik]

Attachment: Bugs in /dom

Comment 1

[Alexander L. Slovesnik]

Attachment: Bugs in /toolkit

Comment 2

[Tim Babych]

Thanks. according to http://wiki.mozilla.org/Firefox2/L10n_Requirements#addons.mozilla.org_.28AMO.29, the right way to refer to AMO is through %LOCALE%, that will be fixed. 

But is it really a mistake to mention &brandShortName; a bit more often than it was in the original?

Comment 3

[Alexander L. Slovesnik]

(In reply to comment #2)
> But is it really a mistake to mention &brandShortName; a bit more often
> than it was in the original?
Yes, that's mistake.
[01:12:34]	<Unghost>	Pike: Do you know is it OK to use &brandShortName; in dom/chrome/netError.dtd ?
[01:13:22]	I remember some bugs about it, it breaked Camino or some non-browser apps...
[01:14:04]	<Pike>	yeah, camino will break, you shouldn't do that

Comment 4

[Axel Hecht [:Pike]]

Yes, in dom, using brandShortName is a bug. You can in http://lxr.mozilla.org/l10n/source/uk/browser/chrome/overrides/netError.dtd due to the 

<!ENTITY % brandDTD SYSTEM "chrome://branding/locale/brand.dtd">
  %brandDTD;

magic on top. Which you mustn't use in dom, please, as embedding apps aren't required to have chrome://branding/locale/brand.dtd.

Comment 5

[Alexander L. Slovesnik]

(In reply to comment #2)
> Thanks. according to
> http://wiki.mozilla.org/Firefox2/L10n_Requirements#addons.mozilla.org_.28AMO.29,
> the right way to refer to AMO is through %LOCALE%, that will be fixed. 
BTW, you'd better change "http" to "https" for extensions.getMoreExtensionsURL and extensions.getMoreThemesURL in chrome\mozapps\extensions\extensions.properties
See Bug 384897 for explanation.

Comment 6

[Axel Hecht [:Pike]]

We should block branching on these bugs, too. Thanks to Alexander for catching those.

Comment 7

[Alexander L. Slovesnik]

http://uk.add-ons.mozilla.com/uk/firefox/bookmarks/ in /uk/browser/profile/bookmarks.html also should use "https" instead "http".
See patch in Bug 384897