389666 - Text wraps to second line when focusing link

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[Martijn Wargers (dead)]

Attachment: testcase

See testcase, when focusing the first link, the word after the link wraps to the second line with current trunk build.
This regressed between 2007-06-20 and 2007-06-21, a regression from bug 367177.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Ah, that explains what I've been seeing at the bottom of the Bugzilla page too!

Comment 3

[Jesse Ruderman]

Confirmed on Mac.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

This is the fix. It's bit mixed up with the patch for bug 393096, so I'll wait for that one to land before I push this one.

The problem is that the mTransformedTextOffset field of the MappedFlows is not initialized when we scan, but do not need to recreate, an existing textrun, so setting up the line breaks in that textrun goes haywire. The fix here is to eliminate that field, we can use a gfxSkipCharsIterator to compute the offset of each MappedFlow in the textrun.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

This is the patch now that 393096 has landed.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I'd like to get this into M9 now that we have a patch. It fixed layout regressions on real sites such as http://www.google.com/ig.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

going for new branch approval procedure

Comment 8

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 285576 [details] [diff] [review]
fix

Approved for M9, please land ASAP.

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I checked in a reftest based on a test in bug 389468.

Comment 11

[Marcia Knous [:marcia]]

Using Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a9pre) Gecko/2007102504 Minefield/3.0a9pre  and the testcase in the bug, I see slightly different layout between the branch and the trunk, at least on the Mac. Screenshots coming. Martijn mentions that the font sizes seem to be different between trunk and branch and that should be a separate bug.

Comment 12

[Marcia Knous [:marcia]]

Attachment: Branch rendering of testcase on Intel Mac

Comment 13

[Marcia Knous [:marcia]]

Attachment: Trunk rendering of testcase on Intel Mac

Comment 14

[Robert O'Callahan (:roc) (email my personal email if necessary)]

The difference is probably just a slightly smaller font on trunk, so not significant.

Comment 15

[Marcia Knous [:marcia]]

verified fixed using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre) Gecko/2007102504 Minefield/3.0a9pre. Roc has addressed my concerns about the mac rendering in Comment 14.