Closed Bug 389666 Opened 17 years ago Closed 16 years ago

Text wraps to second line when focusing link


(Core :: Layout, defect)

Not set





(Reporter: martijn.martijn, Assigned: roc)




(Keywords: regression, testcase, Whiteboard: [dbaron-1.9:RwCt])


(4 files, 1 obsolete file)

Attached file testcase
See testcase, when focusing the first link, the word after the link wraps to the second line with current trunk build.
This regressed between 2007-06-20 and 2007-06-21, a regression from bug 367177.
Ah, that explains what I've been seeing at the bottom of the Bugzilla page too!
Assignee: nobody → roc
Flags: blocking1.9? → blocking1.9+
Confirmed on Mac.
OS: Windows XP → All
Hardware: PC → All
Attached patch fix (obsolete) — Splinter Review
This is the fix. It's bit mixed up with the patch for bug 393096, so I'll wait for that one to land before I push this one.

The problem is that the mTransformedTextOffset field of the MappedFlows is not initialized when we scan, but do not need to recreate, an existing textrun, so setting up the line breaks in that textrun goes haywire. The fix here is to eliminate that field, we can use a gfxSkipCharsIterator to compute the offset of each MappedFlow in the textrun.
Whiteboard: [depends on 393096]
Whiteboard: [depends on 393096] → [depends on 393096][dbaron-1.9:RwCt]
Attached patch fixSplinter Review
This is the patch now that 393096 has landed.
Attachment #282251 - Attachment is obsolete: true
Attachment #285576 - Flags: review?(smontagu)
Whiteboard: [depends on 393096][dbaron-1.9:RwCt] → [needs review][dbaron-1.9:RwCt]
Attachment #285576 - Flags: review?(smontagu) → review+
I'd like to get this into M9 now that we have a patch. It fixed layout regressions on real sites such as
Target Milestone: --- → mozilla1.9 M9
Whiteboard: [needs review][dbaron-1.9:RwCt] → [dbaron-1.9:RwCt]
Whiteboard: [dbaron-1.9:RwCt] → [dbaron-1.9:RwCt][need landing]
going for new branch approval procedure
Target Milestone: mozilla1.9 M9 → ---
Target Milestone: --- → mozilla1.9 M9
Comment on attachment 285576 [details] [diff] [review]

Approved for M9, please land ASAP.
Attachment #285576 - Flags: approval1.9? → approval1.9+
checked in
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: [dbaron-1.9:RwCt][need landing] → [dbaron-1.9:RwCt]
I checked in a reftest based on a test in bug 389468.
Flags: in-testsuite+
Using Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a9pre) Gecko/2007102504 Minefield/3.0a9pre  and the testcase in the bug, I see slightly different layout between the branch and the trunk, at least on the Mac. Screenshots coming. Martijn mentions that the font sizes seem to be different between trunk and branch and that should be a separate bug.
The difference is probably just a slightly smaller font on trunk, so not significant.
verified fixed using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre) Gecko/2007102504 Minefield/3.0a9pre. Roc has addressed my concerns about the mac rendering in Comment 14.
You need to log in before you can comment on or make changes to this bug.