Open Bug 389698 Opened 17 years ago Updated 1 month ago

Header not included when Bugzilla fails to send email on bug creation

Categories

(Bugzilla :: Creating/Changing Bugs, defect)

defect
Not set
minor

Tracking

()

People

(Reporter: laoseth, Unassigned)

References

()

Details

(Keywords: helpwanted)

Attachments

(2 files, 1 obsolete file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.5) Gecko/20070713 Firefox/2.0.0.5
Build Identifier: Bugzilla 3.0

If bugzilla errors out trying to send email on bug creation, the error page does not include the header, and therefore none of the css, making the page hard to read and making the error look more serious than it truly is.

Reproducible: Always

Steps to Reproduce:
1. Set the server to send mail through smtp, but give it a non existent SMTP server address
2. Add a new bug into Bugzilla

Actual Results:  
Shows an exploded, ugly error page

Expected Results:  
A error page with the header included at the top, that keeps the look and feel of non-error pages

It appears the error stems from header_done being set to 1 on line 42 of bug/create/created.html.tmpl.  If this is removed, the header is shown, though I am not sure if this could create a double header in some situations.  In other pages, it seems that the header is included, and header_done is set in the results.html.tmpl instead (admin/products/updated.html.tmpl)
What was the error you actually got? I think you're probably right about this, but if header_done is set, then that means we've actually printed the header, so that shouldn't be a problem...

A screenshot might be good, here, too.
OS: Windows XP → All
Hardware: PC → All
Assignee: ui → create-and-change
Component: User Interface → Creating/Changing Bugs
Attached file Ugly Error Page
This is what would come up before I overrode header_done.
Okay. Well, the screenshot confirms it. It is indeed minor, but it'd be something good for somebody to look into.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Whiteboard: [Good Intro Bug]
Version: unspecified → 3.0
I looked into reproducing the malfunction here but can't find a way to create bug reports.  I'm guessing as a new guy I don't have all the permissions I need.  Could the admin get back with me if it's a permissions issue?  I need these set so I can work on issues like these and check the results of any changes I make.

Mike
Attachment #356688 - Flags: review?(mkanat) → review-
Comment on attachment 356688 [details] [diff] [review]
moved header = 1 below the send mail part

>-[% header_done = 1 %]
>-
> [% FOREACH item = sentmail %]

If you don't set header_done at this point, the header is generated for each bug depending on the new bug. I could track that the problem occurs when code-error.html.tmpl is called by ThrowCodeError(). And I have no idea why this call is a problem.

Your patch fixes the problem because code-error.html.tmpl sees header_done as being undefined, and so call global/header.html.mtpl itself again. But for the reason above, this is not acceptable.
Keywords: helpwanted, qawanted
Whiteboard: [Good Intro Bug]
Keywords: qawanted
Attachment #9385778 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: