Closed Bug 389735 Opened 17 years ago Closed 15 years ago

Unable to open a message in a tab when using the vertical layout

Categories

(Thunderbird :: Mail Window Front End, defect, P2)

Product:
Thunderbird
Component:
Mail Window Front End
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 3.0b1

People

(Reporter: mscott, Assigned: philor)

References

Details

Attachments

(1 file)

Fix v.1
1.39 KB, patch
mkmelin
: review+
Details | Diff | Splinter Review 
Current trunk nightly. I think I may have mentioned this before in the tab bug.

If you use the vertical view, and you open a message in a tab, the tab is messed up. We aren't collapsing the right elements.
OS: Windows Vista → All
Hardware: PC → All
Version: 2.0 → Trunk
Attached patch Fix v.1 — — Splinter Review 
Forgot all about this, until I switched to using vertical, and thought we'd newly broken something.
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
Attachment #344832 - Flags: review?(mkmelin+mozilla)
Blocks: thundertab
Flags: wanted-thunderbird3+
Priority: -- → P2
Comment on attachment 344832 [details] [diff] [review]
Fix v.1

>+  if (layout == kVerticalPaneConfig)
>+  {
>+    document.getElementById("threadTree").collapsed = collapse;
>+  } else {
>+    document.getElementById("displayDeck").collapsed = collapse;
>+  }

Nit: no need for the braces. r=mkmelin
Attachment #344832 - Flags: review?(mkmelin+mozilla) → review+
http://hg.mozilla.org/comm-central/rev/5483391f6d47

I really wanted to blame those braces on style-of-the-file, but I had to page up three times to get to another set, so that's going to be a tough sell.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b1
You need to log in before you can comment on or make changes to this bug.