389903 - Autocomplete custom keywords with parameters (but only after I type a space)

Status: NEW

Description

[Adam Katz]

Mozilla already keeps track of the Location toolbar's history and past form inputs.  It would be nice to see Mozilla keep track of arguments given to Custom Keywords, so that autocomplete can come into play.

Reproducible: Always

Steps to reproduce:
1. Set up a bookmark to http://google.com/search?q=%s with Keyword "google"
2. Clear the Location bar and type "google mozilla" in its place, then hit enter
3. Clear the Location bar and type "google mozi" in its place (don't hit enter)

Actual results:
Step 2 loads a Google search for "mozilla" and puts "http://google.com/search?q=mozilla" into the history.  Step three does nothing.

Desired results:
Step 2 loads a Google search for "mozilla" and puts "http://google.com/search?q=mozilla" and "google mozilla" into the history.  Step 3 uses autocomplete to show the user that "google mozilla" can be selected.


So far, this is a duplicate of bug 79319, which is a duplicate of bug 196297.

I'd like to see the argument only after hitting <space>, so let's continue:
1. Set up a bookmark to http://google.com/search?q=%s with Keyword "google"
2. Clear the Location bar and type "google mozilla" in its place, then hit enter
3. Clear the Location bar and type "google mozi" in its place (don't hit enter)
4. Clear the Location bar and type "google money" in its place, then hit enter
5. Clear the Location bar and type "google.com" in its place, then hit enter
6. Clear the Location bar and type "google" in its place (don't hit enter)
7. Add a space on the end of the location bar (so it says "google ")

Actual results:
Step 2 loads a Google search for "mozilla" and puts "http://google.com/search?q=mozilla" into the history.  Step three does nothing.  Step 4 will show you what Google thinks of money, step 5 will give you Google's front page, and step 6 will give you a bunch of past google search URIs but no keyword-based searches.  Step 7 clears the autocomplete drop-down.

Desired results:
Step 2 loads a Google search for "mozilla" and puts "http://google.com/search?q=mozilla" and "google" into the history, and "google mozilla" into the history for keyword searches on "google."  Step 3 uses autocomplete to show the user that "google mozilla" can be selected.  Step 4 will show you what Google thinks of money, step 5 will give you Google's front page, and step 6 will put the recently entered keyword "google" on top of the list of past Google search URIs, but no keyword-based searches will appear.  Step 7 will show only the search history in the autocompletion drop-down: "mozilla" and "money."


This is obviously low-priority because the quick-search bar already exhibits this behavior, and it would be mostly solved by a fix to bug 196297, but some people (like myself) prefer to use the more customizable search via keywords, utilizing the larger space provided by the location bar (with the search bar removed).

Comment 1

[[:Aleksej]]

See also bug 418095: similar intent, but considering the new autocomplete with
tagging system.

Comment 2

[Delplace]

I vote for this bug because I always use the Location bar for my searches. I would love it to remember my searches and autocomplete with them, as the Search bar does.

Actually I just assign a keyword to each of my dozens of search plugin. So I don't have to use the mouse, nor to browse manually the dozens of plugins for a particular search. The best enhancement i can think of would be to merge the keyword searches history with the Search bar history :
1. Select location bar
2. Type in an existing search keyword (either bookmark or search plugin)
3. Type space
4. HERE the location bar suggests and autocompletes with all previous searches (whether typed in Location bar or in Search bar).

Greets, V.

Comment 3

[Henrik Skupin (:whimboo)]

Edward, is it something we can improve?

Comment 5

[Heiko Baums]

Well this bug report is almost 3 years old. It would be nice, if this could be implemented, because it's a quite important feature.

Try to remember and repeat several search terms like "gg foo1 foo2 foo3 foo4 ..." for a research in the web.

This autocompletion should not only be implemented for bookmark keywords as the original reporter mentioned, but also for search bar keywords as Delplace mentioned.

If I enter "gg foo" in the first search in the awesome bar, where gg is my keyword for Google, and enter "gg f" the second time, it should autocomplete to or display "gg foo" in the dropdown list.