196297 - typed urls with spaces in them do not enter global history

Status: RESOLVED WONTFIX

(Toolkit :: Places, defect, P5)

Description

[Nisheeth Ranjan]

Opening as an offshoot of the discussion in bug 161531.  

sessionhistoryUI.js:

+
+       var url = entryToAdd.Value;
+       if (url.indexOf(" ") == -1) {
+         var fixedUpURI = gURIFixup.createFixupURI(url, 0);
+         gGlobalHistory.markPageAsTyped(fixedUpURI.spec);
+       }
+
        // Put the value as it was typed by the user in to RDF
        // Insert it to the beginning of the list.
-       var fixedUpURI = gURIFixup.createFixupURI(entryToAdd.Value, 0);
-       gGlobalHistory.markPageAsTyped(fixedUpURI.spec);

The above patch is from attachment 70207 [details] [diff] [review], the patch that fixed bug 126320
(Invalid typed urls should be hidden and expire quickly). 
nsGlobalHistory::MarkPageAsTyped() only gets called if the typed url doesn't
have a space in it.  This is wrong behavior because typed js urls can have
spaces in them and should get entered into history in order to be consistent.

Can data urls have spaces in them?

Comment 1

[timeless]

sure data urls often have spaces in them:

"data:text,hello world"

also bookmark keywords will have spaces in them:
"bug 196297" where 'bug' is a keyword for a bookmark to
http://bugzilla.mozilla.org/show_bug.cgi?id=%s

Comment 2

[Jesse Ruderman]

*** Bug 79319 has been marked as a duplicate of this bug. ***

Comment 3

[Nisheeth Ranjan]

Updating summary to make it more accurate.

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

javascript: and data: are not stored in history anyway, typed is somehow losing its importance today (we are looking into better signals for the user workflow than having typed a url, moreover today typed is applied to far too many things, see bug 1330343)
Overall this bug is not useful.