Menubar menus flicker when they are opened/closed. (spawned from bug 389931) STEPS TO REPRODUCE 1. start Firefox 2. click on "File" in the menubar 3. move the mouse to the right over the menubar ACTUAL RESULTS Menus are opened/closed as expected, but they flicker more than they used to. The UI seems sluggish. PLATFORM AND BUILDS TESTED Bug occurs in trunk on Linux. Haven't tested other platforms. Regression window: 2007070404 -- 2007070504. I have verified that bug 279703 caused it by local backout.
Created attachment 278990 [details] [diff] [review] Use synchronous In the existing code, the first menu is hiding asynchronously followed by the new menu opening asynchronously. This change makes it so that both are still done asynchronously, but together in a single step. Also, fix up the test as the inactivate/activate is done together in one step now.
Comment on attachment 278990 [details] [diff] [review] Use synchronous >Index: layout/xul/base/src/nsMenuBarFrame.cpp >+ NS_DispatchToCurrentThread(event); >+ > return NS_OK; I'd |return NS_DispatchToCurrentThread(event);| r+sr=bzbarsky with that. Have I mentioned how much easier the popup manager is to work with than the old code? ;)
Comment on attachment 278990 [details] [diff] [review] Use synchronous a1.9=dbaron
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Component: XP Toolkit/Widgets: Menus → XUL
QA Contact: xptoolkit.menus → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.