389996 - Menubar menus flicker when they are opened/closed

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Mats Palmgren (inactive)]

Menubar menus flicker when they are opened/closed.
(spawned from bug 389931)

STEPS TO REPRODUCE
1. start Firefox
2. click on "File" in the menubar
3. move the mouse to the right over the menubar

ACTUAL RESULTS
Menus are opened/closed as expected, but they flicker more than they used to.
The UI seems sluggish.

PLATFORM AND BUILDS TESTED
Bug occurs in trunk on Linux.  Haven't tested other platforms.
Regression window:  2007070404 -- 2007070504.
I have verified that bug 279703 caused it by local backout.

Comment 2

[Neil Deakin]

Attachment: Use synchronous

In the existing code, the first menu is hiding asynchronously followed by the new menu opening asynchronously. This change makes it so that both are still done asynchronously, but together in a single step.

Also, fix up the test as the inactivate/activate is done together in one step now.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 278990 [details] [diff] [review]
Use synchronous

>Index: layout/xul/base/src/nsMenuBarFrame.cpp
>+  NS_DispatchToCurrentThread(event);
>+
>   return NS_OK;

I'd |return NS_DispatchToCurrentThread(event);|

r+sr=bzbarsky with that.

Have I mentioned how much easier the popup manager is to work with than the old code?  ;)

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 278990 [details] [diff] [review]
Use synchronous

a1.9=dbaron