Closed Bug 389996 Opened 15 years ago Closed 15 years ago

Menubar menus flicker when they are opened/closed

Categories

(Core :: XUL, defect)

x86
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: MatsPalmgren_bugz, Assigned: enndeakin)

References

Details

(Keywords: regression)

Attachments

(1 file)

Menubar menus flicker when they are opened/closed.
(spawned from bug 389931)

STEPS TO REPRODUCE
1. start Firefox
2. click on "File" in the menubar
3. move the mouse to the right over the menubar

ACTUAL RESULTS
Menus are opened/closed as expected, but they flicker more than they used to.
The UI seems sluggish.

PLATFORM AND BUILDS TESTED
Bug occurs in trunk on Linux.  Haven't tested other platforms.
Regression window:  2007070404 -- 2007070504.
I have verified that bug 279703 caused it by local backout.
Duplicate of this bug: 394213
OS: Linux → All
Flags: blocking1.9?
Attached patch Use synchronousSplinter Review
In the existing code, the first menu is hiding asynchronously followed by the new menu opening asynchronously. This change makes it so that both are still done asynchronously, but together in a single step.

Also, fix up the test as the inactivate/activate is done together in one step now.
Assignee: nobody → enndeakin
Status: NEW → ASSIGNED
Attachment #278990 - Flags: superreview?(bzbarsky)
Attachment #278990 - Flags: review?(bzbarsky)
Comment on attachment 278990 [details] [diff] [review]
Use synchronous

>Index: layout/xul/base/src/nsMenuBarFrame.cpp
>+  NS_DispatchToCurrentThread(event);
>+
>   return NS_OK;

I'd |return NS_DispatchToCurrentThread(event);|

r+sr=bzbarsky with that.

Have I mentioned how much easier the popup manager is to work with than the old code?  ;)
Attachment #278990 - Flags: superreview?(bzbarsky)
Attachment #278990 - Flags: superreview+
Attachment #278990 - Flags: review?(bzbarsky)
Attachment #278990 - Flags: review+
Attachment #278990 - Flags: approval1.9?
Comment on attachment 278990 [details] [diff] [review]
Use synchronous

a1.9=dbaron
Attachment #278990 - Attachment description: Use syncronous → Use synchronous
Attachment #278990 - Flags: approval1.9? → approval1.9+
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Component: XP Toolkit/Widgets: Menus → XUL
QA Contact: xptoolkit.menus → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.