390147 - Export calendar is not wired up correctly

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[Michael Büttner (no reviews TFN)]

'Export calendar' is only available if an item has been selected, but since we're exporting the entire calendar this doesn't make sense. The relevant source location can be found at [1]. This is an unfortunate copy'n'paste but that has been introduced by Bug #371916.

Wouldn't it be a good idea to consolidate the commands used for Sunbird and Lightning? Is there any reason for defining the commands twice, once in sunbird/base/content/calendar-sets.inc and once more in calendar/lightning/content/messenger-overlay-sidebar.xul? We could reduce such regressions if we'd consolidate the code that takes care of this stuff.

[1] http://lxr.mozilla.org/mozilla1.8/source/calendar/lightning/content/messenger-overlay-sidebar.xul#170

Comment 1

[Michael Büttner (no reviews TFN)]

See [1] for Sunbird's and [2] for Lightning's version of the export command. Sunbird exports the selected events while Lightning always export the entire calendar. Christian, in order to stay consistent we should decide which route to take. What's your opinion on that?

[1] http://lxr.mozilla.org/mozilla1.8/source/calendar/sunbird/base/content/calendar-sets.inc#87
[2] http://lxr.mozilla.org/mozilla1.8/source/calendar/lightning/content/messenger-overlay-sidebar.xul#170

Comment 2

[Stefan Sitter [:ssitter]]

(In reply to comment #1)
> Sunbird exports the selected events while Lightning always
> export the entire calendar.

Sunbird offers both export/publish functionality: You can either export/publish the selected items or you can export/publish the entire calendar. 

Lightning currently lacks the ability to export/publish the selected items.

Comment 3

[Michael Büttner (no reviews TFN)]

Attachment: patch v1

This patch addresses the issue that "Export Calendar" is disabled if no item has been selected, but since we're exporting the entire calendar this shouldn't be taken into account.

If we decide to consolidate Sunbird's and Lightning's functionality, this is just part of the solution. But I'm submitting this patch to get the issue going.

Comment 5

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 274466 [details] [diff] [review]
patch v1

r=philipp for this part. 

We should either file a followup bug to take care of the unification, or morph this bug after the checkin.

Please also file a follow-up bug for creating a common set of commandsets. I was also thinking of this when creating the unify calendar list patch, but didn't come around to filing that bug yet.

Comment 6

[Christian Jansen]

Comment on attachment 274466 [details] [diff] [review]
patch v1

In general Export should also work if the Calendar is selected in the Calendar List only. (Same for Publish & Edit) r=christian with that change.

Comment 7

[Michael Büttner (no reviews TFN)]

(In reply to comment #6)
> (From update of attachment 274466 [details] [diff] [review])
> In general Export should also work if the Calendar is selected in the Calendar
> List only. (Same for Publish & Edit) r=christian with that change.
This patch makes the "Export Calendar" option always work. So, maybe I'm plain stupid, but I don't understand what you're trying to tell me. :-)

Comment 9

[Philipp Kewisch [:Fallen][📱📆]]

Christian, could you please take another look at this bug? We should consolidate the export mechanism for Sunbird and Lightning. I propose the following:

Short-Term:
* Allow Exporting either the whole calendar, or only the selection from both apps.
* Alternatively, just allow what the above patch does, to export the whole calendar also via menu.

Mid-Term:
* Create a wizard for export (and import), in which you can choose either the whole calendar, or just the selected items. This can be nicely integrated in the Thunderbird export wizard (see bug 389152 and bug 389154), and be a separte wizard in Sunbird (see bug 167255)

Comment 10

[Michael Büttner (no reviews TFN)]

Christian, any update on this issue? I still don't know what to do with this patch. This just makes the export command *always* available, it doesn't change the semantics.

Comment 11

[Christian Jansen]

Comment on attachment 274466 [details] [diff] [review]
patch v1

ui=christian

Comment 12

[Michael Büttner (no reviews TFN)]

The follow-up bug has already been filed as Bug 390508.

Comment 13

[Michael Büttner (no reviews TFN)]

patch checked in on trunk and MOZILLA_1_8_BRANCH

-> FIXED

Comment 14

[Damian Szczepanik]

verified with
Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.8.1.8pre) Gecko/20071002 Sunbird/0.7

Comment 15

[Stefan Sitter [:ssitter]]

How did you verified a Lightning bug with Sunbird?